warning: The `tool.uv.dev-dependencies` field (used in `pyproject.toml`) is deprecated and will be removed in a future release; use `dependency-groups.dev` instead
Reviewed-on: #518
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [python](https://github.com/actions/python-versions) | uses-with | minor | `3.13` -> `3.14` |
| python | final | minor | `3.13-slim` -> `3.14-slim` |
---
### Release Notes
<details>
<summary>actions/python-versions (python)</summary>
### [`v3.14.0`](https://github.com/actions/python-versions/releases/tag/3.14.0-18313368925): 3.14.0
[Compare Source](https://github.com/actions/python-versions/compare/3.13.8-18331000654...3.14.0-18313368925)
Python 3.14.0
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzguNSIsInVwZGF0ZWRJblZlciI6IjQxLjE0MC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->
Reviewed-on: #513
Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk>
Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
| [pylint](https://github.com/pylint-dev/pylint) ([changelog](https://pylint.readthedocs.io/en/latest/whatsnew/3/)) | `<4.0.0,>=3.3.2` -> `<4.1.0,>=4.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) |
---
### Release Notes
<details>
<summary>pylint-dev/pylint (pylint)</summary>
### [`v4.0.0`](https://github.com/pylint-dev/pylint/releases/tag/v4.0.0)
[Compare Source](https://github.com/pylint-dev/pylint/compare/v3.3.9...v4.0.0)
- Pylint now supports Python 3.14.
- Pylint's inference engine (`astroid`) is now much more precise,
understanding implicit booleanness and ternary expressions. (Thanks [@​zenlyj](https://github.com/zenlyj)!)
Consider this example:
```python
class Result:
errors: dict | None = None
result = Result()
if result.errors:
result.errors[field_key]
### inference engine understands result.errors cannot be None
### pylint no longer raises unsubscriptable-object
```
The required `astroid` version is now 4.0.0. See the [astroid changelog](https://pylint.readthedocs.io/projects/astroid/en/latest/changelog.html#what-s-new-in-astroid-4-0-0) for additional fixes, features, and performance improvements applicable to pylint.
- Handling of `invalid-name` at the module level was patchy. Now,
module-level constants that are reassigned are treated as variables and checked
against `--variable-rgx` rather than `--const-rgx`. Module-level lists,
sets, and objects can pass against either regex.
Here, `LIMIT` is reassigned, so pylint only uses `--variable-rgx`:
```python
LIMIT = 500 # [invalid-name]
if sometimes:
LIMIT = 1 # [invalid-name]
```
If this is undesired, refactor using *exclusive* assignment so that it is
evident that this assignment happens only once:
```python
if sometimes:
LIMIT = 1
else:
LIMIT = 500 # exclusive assignment: uses const regex, no warning
```
Lists, sets, and objects still pass against either `const-rgx` or `variable-rgx`
even if reassigned, but are no longer completely skipped:
```python
MY_LIST = []
my_list = []
My_List = [] # [invalid-name]
```
Remember to adjust the [regexes](https://pylint.readthedocs.io/en/latest/user_guide/messages/convention/invalid-name.html) and [allow lists](https://pylint.readthedocs.io/en/latest/user_guide/configuration/all-options.html#good-names) to your liking.
## Breaking Changes
- `invalid-name` now distinguishes module-level constants that are assigned only once
from those that are reassigned and now applies `--variable-rgx` to the latter. Values
other than literals (lists, sets, objects) can pass against either the constant or
variable regexes (e.g. "LOGGER" or "logger" but not "LoGgEr").
Remember that `--good-names` or `--good-names-rgxs` can be provided to explicitly
allow good names.
Closes [#​3585](https://github.com/pylint-dev/pylint/issues/3585)
- The unused `pylintrc` argument to `PyLinter.__init__()` is deprecated
and will be removed.
Refs [#​6052](https://github.com/pylint-dev/pylint/issues/6052)
- Commented out code blocks such as `# bar() # TODO: remove dead code` will no longer emit `fixme`.
Refs [#​9255](https://github.com/pylint-dev/pylint/issues/9255)
- `pyreverse` `Run` was changed to no longer call `sys.exit()` in its `__init__`.
You should now call `Run(args).run()` which will return the exit code instead.
Having a class that always raised a `SystemExit` exception was considered a bug.
Normal usage of pyreverse through the CLI will not be affected by this change.
Refs [#​9689](https://github.com/pylint-dev/pylint/issues/9689)
- The `suggestion-mode` option was removed, as pylint now always emits user-friendly hints instead
of false-positive error messages. You should remove it from your conf if it's defined.
Refs [#​9962](https://github.com/pylint-dev/pylint/issues/9962)
- The `async.py` checker module has been renamed to `async_checker.py` since `async` is a Python keyword
and cannot be imported directly. This allows for better testing and extensibility of the async checker functionality.
Refs [#​10071](https://github.com/pylint-dev/pylint/issues/10071)
- The message-id of `continue-in-finally` was changed from `E0116` to `W0136`. The warning is
now emitted for every Python version since it will raise a syntax warning in Python 3.14.
See [PEP 765 - Disallow return/break/continue that exit a finally block](https://peps.python.org/pep-0765/).
Refs [#​10480](https://github.com/pylint-dev/pylint/issues/10480)
- Removed support for `nmp.NaN` alias for `numpy.NaN` being recognized in ':ref:`nan-comparison`'. Use `np` or `numpy` instead.
Refs [#​10583](https://github.com/pylint-dev/pylint/issues/10583)
- Version requirement for `isort` has been bumped to >=5.0.0.
The internal compatibility for older `isort` versions exposed via `pylint.utils.IsortDriver` has
been removed.
Refs [#​10637](https://github.com/pylint-dev/pylint/issues/10637)
## New Features
- `comparison-of-constants` now uses the unicode from the ast instead of reformatting from
the node's values preventing some bad formatting due to `utf-8` limitation. The message now uses
`"` instead of `'` to better work with what the python ast returns.
Refs [#​8736](https://github.com/pylint-dev/pylint/issues/8736)
- Enhanced pyreverse to properly distinguish between UML relationship types (association, aggregation, composition) based on object ownership semantics. Type annotations without assignment are now treated as associations, parameter assignments as aggregations, and object instantiation as compositions.
Closes [#​9045](https://github.com/pylint-dev/pylint/issues/9045)
Closes [#​9267](https://github.com/pylint-dev/pylint/issues/9267)
- The `fixme` check can now search through docstrings as well as comments, by using
`check-fixme-in-docstring = true` in the `[tool.pylint.miscellaneous]` section.
Closes [#​9255](https://github.com/pylint-dev/pylint/issues/9255)
- The `use-implicit-booleaness-not-x` checks now distinguish between comparisons
used in boolean contexts and those that are not, enabling them to provide more accurate refactoring suggestions.
Closes [#​9353](https://github.com/pylint-dev/pylint/issues/9353)
- The verbose option now outputs the filenames of the files that have been checked.
Previously, it only included the number of checked and skipped files.
Closes [#​9357](https://github.com/pylint-dev/pylint/issues/9357)
- colorized reporter now colorizes messages/categories that have been configured as `fail-on` in red inverse.
This makes it easier to quickly find the errors that are causing pylint CI job failures.
Closes [#​9898](https://github.com/pylint-dev/pylint/issues/9898)
- Enhanced support for [@​property](https://github.com/property) decorator in pyreverse to correctly display return types of annotated properties when generating class diagrams.
Closes [#​10057](https://github.com/pylint-dev/pylint/issues/10057)
- Add --max-depth option to pyreverse to control diagram complexity. A depth of 0 shows only top-level packages, 1 shows one level of subpackages, etc.
This helps manage visualization of large codebases by limiting the depth of displayed packages and classes.
Refs [#​10077](https://github.com/pylint-dev/pylint/issues/10077)
- Handle deferred evaluation of annotations in Python 3.14.
Closes [#​10149](https://github.com/pylint-dev/pylint/issues/10149)
- Enhanced pyreverse to properly detect aggregations for comprehensions (list, dict, set, generator).
Closes [#​10236](https://github.com/pylint-dev/pylint/issues/10236)
- `pyreverse`: add support for colorized output when using output format `mmd` (MermaidJS) and `html`.
Closes [#​10242](https://github.com/pylint-dev/pylint/issues/10242)
- pypy 3.11 is now officially supported.
Refs [#​10287](https://github.com/pylint-dev/pylint/issues/10287)
- Add support for Python 3.14.
Refs [#​10467](https://github.com/pylint-dev/pylint/issues/10467)
- Add naming styles for `ParamSpec` and `TypeVarTuple` that align with the `TypeVar` style.
Refs [#​10541](https://github.com/pylint-dev/pylint/issues/10541)
## New Checks
- Add `match-statements` checker and the following message:
`bare-name-capture-pattern`.
This will emit an error message when a name capture pattern is used in a match statement which would make the remaining patterns unreachable.
This code is a SyntaxError at runtime.
Closes [#​7128](https://github.com/pylint-dev/pylint/issues/7128)
- Add new check `async-context-manager-with-regular-with` to detect async context managers used with regular `with` statements instead of `async with`.
Refs [#​10408](https://github.com/pylint-dev/pylint/issues/10408)
- Add `break-in-finally` warning. Using `break` inside the `finally` clause
will raise a syntax warning in Python 3.14.
See `PEP 765 - Disallow return/break/continue that exit a finally block <https://peps.python.org/pep-0765/>`\_.
Refs [#​10480](https://github.com/pylint-dev/pylint/issues/10480)
- Add new checks for invalid uses of class patterns in :keyword:`match`.
- :ref:`invalid-match-args-definition` is emitted if :py:data:`object.__match_args__` isn't a tuple of strings.
- :ref:`too-many-positional-sub-patterns` if there are more positional sub-patterns than specified in :py:data:`object.__match_args__`.
- :ref:`multiple-class-sub-patterns` if there are multiple sub-patterns for the same attribute.
Refs [#​10559](https://github.com/pylint-dev/pylint/issues/10559)
- Add additional checks for suboptimal uses of class patterns in :keyword:`match`.
- :ref:`match-class-bind-self` is emitted if a name is bound to `self` instead of
using an `as` pattern.
- :ref:`match-class-positional-attributes` is emitted if a class pattern has positional
attributes when keywords could be used.
Refs [#​10587](https://github.com/pylint-dev/pylint/issues/10587)
- Add a `consider-math-not-float` message. `float("nan")` and `float("inf")` are slower
than their counterpart `math.inf` and `math.nan` by a factor of 4 (notwithstanding
the initial import of math) and they are also not well typed when using mypy.
This check also catches typos in float calls as a side effect.
The :ref:`pylint.extensions.code_style` need to be activated for this check to work.
Refs [#​10621](https://github.com/pylint-dev/pylint/issues/10621)
## False Positives Fixed
- Fix a false positive for `used-before-assignment` when a variable defined under
an `if` and via a named expression (walrus operator) is used later when guarded
under the same `if` test.
Closes [#​10061](https://github.com/pylint-dev/pylint/issues/10061)
- Fix :ref:`no-name-in-module` for members of `concurrent.futures` with Python 3.14.
Closes [#​10632](https://github.com/pylint-dev/pylint/issues/10632)
## False Negatives Fixed
- Fix false negative for `used-before-assignment` when a `TYPE_CHECKING` import is used as a type annotation prior to erroneous usage.
Refs [#​8893](https://github.com/pylint-dev/pylint/issues/8893)
- Match cases are now counted as edges in the McCabe graph and will increase the complexity accordingly.
Refs [#​9667](https://github.com/pylint-dev/pylint/issues/9667)
- Check module-level constants with type annotations for `invalid-name`.
Remember to adjust `const-naming-style` or `const-rgx` to your liking.
Closes [#​9770](https://github.com/pylint-dev/pylint/issues/9770)
- Fix false negative where function-redefined (E0102) was not reported for functions with a leading underscore.
Closes [#​9894](https://github.com/pylint-dev/pylint/issues/9894)
- We now raise a `logging-too-few-args` for format string with no
interpolation arguments at all (i.e. for something like `logging.debug("Awaiting process %s")`
or `logging.debug("Awaiting process {pid}")`). Previously we did not raise for such case.
Closes [#​9999](https://github.com/pylint-dev/pylint/issues/9999)
- Fix false negative for `used-before-assignment` when a function is defined inside a `TYPE_CHECKING` guard block and used later.
Closes [#​10028](https://github.com/pylint-dev/pylint/issues/10028)
- Fix a false negative for `possibly-used-before-assignment` when a variable is conditionally defined
and later assigned to a type-annotated variable.
Closes [#​10421](https://github.com/pylint-dev/pylint/issues/10421)
- Fix false negative for `deprecated-module` when a `__import__` method is used instead of `import` sentence.
Refs [#​10453](https://github.com/pylint-dev/pylint/issues/10453)
- Count match cases for `too-many-branches` check.
Refs [#​10542](https://github.com/pylint-dev/pylint/issues/10542)
- Fix false-negative where :ref:`unused-import` was not reported for names referenced in a preceding `global` statement.
Refs [#​10633](https://github.com/pylint-dev/pylint/issues/10633)
## Other Bug Fixes
- When displaying unicode with surrogates (or other potential `UnicodeEncodeError`),
pylint will now display a '?' character (using `encode(encoding="utf-8", errors="replace")`)
instead of crashing. The functional tests classes are also updated to handle this case.
Closes [#​8736](https://github.com/pylint-dev/pylint/issues/8736)
- Fixed unidiomatic-typecheck only checking left-hand side.
Closes [#​10217](https://github.com/pylint-dev/pylint/issues/10217)
- Fix a crash caused by malformed format strings when using `.format` with keyword arguments.
Closes [#​10282](https://github.com/pylint-dev/pylint/issues/10282)
- Fix false positive `inconsistent-return-statements` when using `quit()` or `exit()` functions.
Closes [#​10508](https://github.com/pylint-dev/pylint/issues/10508)
- Fix a crash in :ref:`nested-min-max` when using `builtins.min` or `builtins.max`
instead of `min` or `max` directly.
Closes [#​10626](https://github.com/pylint-dev/pylint/issues/10626)
- Fixed a crash in :ref:`unnecessary-dict-index-lookup` when the index of an enumerated list
was deleted inside a for loop.
Closes [#​10627](https://github.com/pylint-dev/pylint/issues/10627)
## Other Changes
- Remove support for launching pylint with Python 3.9.
Code that supports Python 3.9 can still be linted with the `--py-version=3.9` setting.
Refs [#​10405](https://github.com/pylint-dev/pylint/issues/10405)
## Internal Changes
- Modified test framework to allow for different test output for different Python versions.
Refs [#​10382](https://github.com/pylint-dev/pylint/issues/10382)
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNDYuMCIsInVwZGF0ZWRJblZlciI6IjQxLjE0Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->
Reviewed-on: https://git.tainton.uk/repos/webexmemebot/pulls/516
Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk>
Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNDYuMCIsInVwZGF0ZWRJblZlciI6IjQxLjE0Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->
Reviewed-on: #517
Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk>
Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzUuNSIsInVwZGF0ZWRJblZlciI6IjQxLjEzNS41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->
Reviewed-on: #512
Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk>
Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzEuOSIsInVwZGF0ZWRJblZlciI6IjQxLjEzMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->
Reviewed-on: #509
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [hadolint/hadolint-action](https://github.com/hadolint/hadolint-action) | action | minor | `v3.2.0` -> `v3.3.0` |
---
### Release Notes
<details>
<summary>hadolint/hadolint-action (hadolint/hadolint-action)</summary>
### [`v3.3.0`](https://github.com/hadolint/hadolint-action/releases/tag/v3.3.0)
[Compare Source](https://github.com/hadolint/hadolint-action/compare/v3.2.0...v3.3.0)
##### Features
- trigger release workflow ([2332a7b](2332a7b74a))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMjMuMCIsInVwZGF0ZWRJblZlciI6IjQxLjEyMy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->
Reviewed-on: #508
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMjIuMyIsInVwZGF0ZWRJblZlciI6IjQxLjEyMi4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->
Reviewed-on: #507
Reviewed-by: Luke Tainton <luke@tainton.uk>
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMTMuMyIsInVwZGF0ZWRJblZlciI6IjQxLjExMy4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->
Reviewed-on: #505
Reviewed-by: Luke Tainton <luke@tainton.uk>
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [actions/setup-python](https://github.com/actions/setup-python) | action | major | `v5` -> `v6` |
---
### Release Notes
<details>
<summary>actions/setup-python (actions/setup-python)</summary>
### [`v6`](https://github.com/actions/setup-python/compare/v5...v6)
[Compare Source](https://github.com/actions/setup-python/compare/v5...v6)
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45MS40IiwidXBkYXRlZEluVmVyIjoiNDEuOTEuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9kZXBlbmRlbmNpZXMiXX0=-->
Reviewed-on: #504
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [hadolint/hadolint-action](https://github.com/hadolint/hadolint-action) | action | minor | `v3.1.0` -> `v3.2.0` |
---
### Release Notes
<details>
<summary>hadolint/hadolint-action (hadolint/hadolint-action)</summary>
### [`v3.2.0`](https://github.com/hadolint/hadolint-action/releases/tag/v3.2.0)
[Compare Source](https://github.com/hadolint/hadolint-action/compare/v3.1.0...v3.2.0)
##### Features
- new minor release ([3fc49fb](3fc49fb50d))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45MS40IiwidXBkYXRlZEluVmVyIjoiNDEuOTEuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9kZXBlbmRlbmNpZXMiXX0=-->
Reviewed-on: #503
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45MS4yIiwidXBkYXRlZEluVmVyIjoiNDEuOTEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9kZXBlbmRlbmNpZXMiXX0=-->
Reviewed-on: #502
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44Mi4xMCIsInVwZGF0ZWRJblZlciI6IjQxLjgyLjEwIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->
Reviewed-on: #501
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS42MS4wIiwidXBkYXRlZEluVmVyIjoiNDEuNjEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9kZXBlbmRlbmNpZXMiXX0=-->
Reviewed-on: #498
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS41MS4xIiwidXBkYXRlZEluVmVyIjoiNDEuNTEuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9kZXBlbmRlbmNpZXMiXX0=-->
Reviewed-on: #497
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS40My41IiwidXBkYXRlZEluVmVyIjoiNDEuNDMuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9kZXBlbmRlbmNpZXMiXX0=-->
Reviewed-on: #496
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS40MC4wIiwidXBkYXRlZEluVmVyIjoiNDEuNDAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9kZXBlbmRlbmNpZXMiXX0=-->
Reviewed-on: #495
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4zMi4xIiwidXBkYXRlZEluVmVyIjoiNDEuMzIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9kZXBlbmRlbmNpZXMiXX0=-->
Reviewed-on: #494
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4yMy4yIiwidXBkYXRlZEluVmVyIjoiNDEuMjMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9kZXBlbmRlbmNpZXMiXX0=-->
Reviewed-on: #492
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xLjQiLCJ1cGRhdGVkSW5WZXIiOiI0MS4xLjQiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInR5cGUvZGVwZW5kZW5jaWVzIl19-->
Reviewed-on: #491
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC41Mi4wIiwidXBkYXRlZEluVmVyIjoiNDAuNTIuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9kZXBlbmRlbmNpZXMiXX0=-->
Reviewed-on: #490
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Okay, let's break down this Git diff. I'll explain the changes in the context of the overall project.
**Overall:**
This pull request appears to be updating dependencies, and making a corresponding code change to reflect an API change in one of those dependencies, `webexteamssdk`. The project seems to be a Webex bot application, utilizing the Webex Teams SDK to interact with Webex.
**File Breakdown:**
1. `app/meme.py`
```diff
--- a/app/meme.py
+++ b/app/meme.py
@@ -2,10 +2,10 @@
from webex_bot.models.command import Command
from webex_bot.models.response import Response, response_from_adaptive_card
- from webexteamssdk.models.cards import (
+ from webexpythonsdk.models.cards import (
AdaptiveCard,
Choice,
- Choices,
+ ChoiceSet,
Column,
ColumnSet,
FontSize,
@@ -13,7 +13,7 @@ from webexteamssdk.models.cards import (
Text,
TextBlock,
)
- from webexteamssdk.models.cards.actions import OpenUrl, Submit
+ from webexpythonsdk.models.cards.actions import OpenUrl, Submit
from app import img
@@ -70,7 +70,7 @@ class MakeMemeCommand(Command):
Column(
width=1,
items=[
- Choices(
+ ChoiceSet(
id="meme_type",
isMultiSelect=False,
choices=[Choice(title=x["name"], value=x["choiceval"]) for x in TEMPLATES],
```
* **`import` statement update:**
* `webexteamssdk` is replaced with `webexpythonsdk`. This indicates that the code is migrating to use a potentially renamed or reorganized SDK.
* The import paths for card models and actions are updated to reflect the new SDK structure (e.g., `webexteamssdk.models.cards` becomes `webexpythonsdk.models.cards`).
* **`Choices` to `ChoiceSet`:**
* The code changes from using a class named `Choices` to `ChoiceSet`. The `Choices` class was probably renamed to `ChoiceSet` in the new SDK. This change is found in the `MakeMemeCommand` class, within the adaptive card definition.
* The purpose of this code is likely to present a user with a set of options to select a meme type, and the `ChoiceSet` renders a dropdown or radio button group in the adaptive card.
2. `uv.lock`
This file is a lock file for the uv package manager, similar to `requirements.txt` with hashes. It specifies the exact versions and dependencies of Python packages used in the project. The changes in this file reflect an update to the project's dependencies. The major changes are:
* **Removal of `revision = 2`:** This line is removed, indicating a change in the lock file's metadata.
* **Version bumps:** Several packages have their versions updated. Some examples include:
* `certifi` updated from `2025.1.31` to `2025.4.26`
* `charset-normalizer` updated from `3.4.1` to `3.4.2`
* `click` updated from `8.1.8` to `8.2.1`
* `coverage` updated from `7.8.0` to `7.8.2`
* `dill` updated from `0.3.9` to `0.4.0`
* `identify` updated from `2.6.9` to `2.6.12`
* `mypy-extensions` updated from `1.0.0` to `1.1.0`
* `packaging` updated from `24.2` to `25.0`
* `pluggy` updated from `1.5.0` to `1.6.0`
* `pylint` updated from `3.3.6` to `3.3.7`
* `urllib3` updated to `2.4.0`
* `webex-bot` updated from `0.5.2` to `0.6.2`
* `webexteamssdk` replaced by `webexpythonsdk` updated to `2.0.4`
* **Removal of `future` package:** This package is removed from the dependencies.
* **Addition of `pygments` package:** This package is added as a dependency with version `2.19.1`.
* **Hash changes:** The hashes for all the updated packages have also changed, which is expected since the package versions are different. The inclusion of hashes ensures that the correct, unaltered versions of the packages are installed.
**Impact and Justification:**
* **Dependency Updates:** Keeping dependencies up-to-date is a standard security practice. Newer versions often include bug fixes, performance improvements, and security patches.
* **API Alignment:** The code change in `app/meme.py` is essential. If `webexteamssdk` was indeed renamed or its API significantly altered in the newer version, the code needs to adapt to use the new class names and import paths. Failing to do so would likely break the meme-making functionality.
* **Lockfile Integrity:** Updating the lockfile (`uv.lock`) is crucial. It ensures that every environment where this project is deployed uses the *exact* same versions of the dependencies, preventing unexpected behavior.
* **Removal of `future`:** The removal of `future` suggests that the code might have been updated to be fully compatible with Python 3, and the package is no longer needed.
* **Addition of `pygments`:** The addition of `pygments` indicates that the code will now use this library.
**In Summary:**
This pull request updates dependencies, adapts the code to API changes in `webexpythonsdk`, adds `pygments` and removes the `future` package, while ensuring dependency consistency through the lockfile. It's a necessary step for maintaining the application's functionality, security, and compatibility with the latest libraries.
Reviewed-on: #488
This pull request focuses on improving the documentation and readability of the Webex meme bot application by adding docstrings and minor formatting adjustments. Here's a breakdown of the changes:
* **Docstrings:**
* Added module-level docstrings to `app/close.py`, `app/img.py`, and `app/main.py` providing a high-level overview of the purpose of each module.
* Added docstrings to classes (`ExitCommand`, `MakeMemeCommand`, `MakeMemeCallback`) describing their role.
* Added docstrings to methods within those classes (`__init__`, `pre_execute`, `execute`, `post_execute`) explaining their functionality, arguments, and return values where applicable. The `get_templates` and `format_meme_string` functions in `app/img.py` have been documented as well.
* **Formatting:**
* Added a line break before the return type annotation in function definitions (e.g., `def execute(...) -> Response:`).
* Added the disable comment `# pylint: disable=line-too-long` to a line in `app/meme.py` to disable pylint for that line.
* Added the disable comment `# pylint: disable=unused-argument` to the `pre_execute`, `execute`, and `post_execute` methods to disable pylint checks about unused arguments. This is because these methods are part of an interface and must have the same signature even if some arguments are unused.
* **Variable Naming:**
* Renamed the `vars` dictionary to `env_vars` in `tests/test_config.py` for better clarity.
* **Test Update:**
* Added a docstring to the `test_config` function in `tests/test_config.py` to explain its functionality.
* **Imports Update:**
* Updated imports in `tests/test_config.py` to disable pylint for wrong-import-position errors using `# pylint: disable=wrong-import-position`.
In essence, these changes enhance the maintainability and understandability of the codebase through comprehensive documentation and minor code style improvements.
Reviewed-on: #487
Okay, I will analyze the provided Git diff and explain the proposed changes.
**Overall Summary**
The diff shows a commented-out job in the `.gitea/workflows/release.yml` file. The job `get_release_id` and its associated steps are being commented out. Also, the `needs` attribute for `create_docker` job has been changed.
**Detailed Explanation**
1. **Commenting out the `get_release_id` job:**
The entire `get_release_id` job block is being commented out. This includes the `name`, `runs-on`, `needs`, `outputs`, and `steps` sections.
```diff
--- a/.gitea/workflows/release.yml
+++ b/.gitea/workflows/release.yml
@@ -23,26 +23,26 @@ jobs:
secrets:
ACTIONS_TOKEN: ${{ secrets.ACTIONS_TOKEN }}
- get_release_id:
- name: Get Release ID
- runs-on: ubuntu-latest
- needs: [tag, create_release]
- outputs:
- releaseid: ${{ steps.getid.outputs.releaseid }}
- steps:
- - name: Get Release ID
- id: getid
- run: |
- rid=$(curl -s -X 'GET' \
- -H 'accept: application/json' \
- '${{ gitea.server_url }}/api/v1/repos/${{ gitea.repository }}/releases/latest' | jq -r '.id')
- echo "releaseid=$rid" >> "$GITEA_OUTPUT"
- echo "$rid"
+ # get_release_id:
+ # name: Get Release ID
+ # runs-on: ubuntu-latest
+ # needs: create_release
+ # outputs:
+ # releaseid: ${{ steps.getid.outputs.releaseid }}
+ # steps:
+ # - name: Get Release ID
+ # - id: getid
+ # - run: |
+ # rid=$(curl -s -X 'GET' \
+ # -H 'accept: application/json' \
+ # '${{ gitea.server_url }}/api/v1/repos/${{ gitea.repository }}/releases/latest' | jq -r '.id')
+ # echo "releaseid=$rid" >> "$GITEA_OUTPUT"
+ # echo "$rid"
```
The original `get_release_id` job was responsible for fetching the ID of the latest release using a `curl` command against the Gitea API. The output `releaseid` was likely intended to be used by subsequent jobs. Commenting this out means this ID will no longer be available.
2. **Modifying the `needs` attribute for the `create_docker` job:**
The `needs` attribute of the `create_docker` job has been modified.
```diff
--- a/.gitea/workflows/release.yml
+++ b/.gitea/workflows/release.yml
@@ -50,7 +50,7 @@
create_docker:
name: Publish Docker Images
runs-on: ubuntu-latest
- needs: tag
+ needs: create_release
steps:
- name: Update Docker configuration
continue-on-error: true
```
The original `needs: tag` has been changed to `needs: create_release`. This means that the `create_docker` job will now only run after the `create_release` job has completed successfully, instead of after the `tag` job.
**Impact and Potential Reasons**
* **Removal of Release ID:** By commenting out `get_release_id`, any downstream jobs relying on the `releaseid` output will likely break. The reason for removing this is not apparent from the diff, but it could be due to:
* The ID is no longer needed.
* The method for obtaining the ID has changed and is implemented elsewhere.
* The job was causing issues and is being temporarily disabled.
* The job was not functioning as intended.
* **Changing Dependency for Docker Image Creation:** Changing the dependency of `create_docker` to `create_release` suggests a change in the intended workflow. Previously, the Docker image creation was triggered by the creation of a tag. Now, it's triggered specifically by the creation of a release. This might be done to ensure that Docker images are only built and published when a formal release is made, rather than on every tag.
It's important to examine the broader context of the pull request and any associated issues to understand the rationale behind these changes more fully.
Reviewed-on: #484
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [astroid](https://github.com/pylint-dev/astroid) | project.dependencies | patch | `<=3.3.9` -> `<=3.3.10` |
---
### Release Notes
<details>
<summary>pylint-dev/astroid (astroid)</summary>
### [`v3.3.10`](https://github.com/pylint-dev/astroid/blob/HEAD/ChangeLog#Whats-New-in-astroid-3310)
[Compare Source](https://github.com/pylint-dev/astroid/compare/v3.3.9...v3.3.10)
\=============================
Release date: 2025-05-10
- Avoid importing submodules sharing names with standard library modules.
Closes [#​2684](https://github.com/pylint-dev/astroid/issues/2684)
- Fix bug where `pylint code.custom_extension` would analyze `code.py` or `code.pyi` instead if they existed.
Closes [pylint-dev/pylint#3631](https://github.com/pylint-dev/pylint/issues/3631)
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC44LjIiLCJ1cGRhdGVkSW5WZXIiOiI0MC44LjIiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInR5cGUvZGVwZW5kZW5jaWVzIl19-->
Reviewed-on: https://git.tainton.uk/repos/webexmemebot/pulls/481
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMzguMiIsInVwZGF0ZWRJblZlciI6IjM5LjIzOC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->
Reviewed-on: #478
Reviewed-by: Luke Tainton <luke@tainton.uk>
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMjEuMCIsInVwZGF0ZWRJblZlciI6IjM5LjIyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->
Reviewed-on: #477
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMTEuNCIsInVwZGF0ZWRJblZlciI6IjM5LjIxMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->
Reviewed-on: #475
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This PR contains the following updates:
| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |
🔧 This Pull Request updates lock files to use the latest dependency versions.
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMDAuMyIsInVwZGF0ZWRJblZlciI6IjM5LjIwMC4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->
Reviewed-on: #474
Reviewed-by: Luke Tainton <luke@tainton.uk>
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
2025-03-19 18:52:21 +01:00
12 changed files with 588 additions and 468 deletions
File diff suppressed because it is too large
Load Diff
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.