repos/webexmemebot
4
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Releases 45 Activity

feat!(deps): upgrade dependencies #488

Merged
luke merged 1 commits from feat/new-sdk into main 2025-06-06 19:53:37 +02:00
Conversation 1 Commits 1 Files Changed 2 +297 -294
luke commented 2025-06-06 19:52:04 +02:00
Owner
Copy Link

Okay, let's break down this Git diff. I'll explain the changes in the context of the overall project.

Overall:

This pull request appears to be updating dependencies, and making a corresponding code change to reflect an API change in one of those dependencies, webexteamssdk. The project seems to be a Webex bot application, utilizing the Webex Teams SDK to interact with Webex.

File Breakdown:

  1. app/meme.py

    --- a/app/meme.py
+++ b/app/meme.py
@@ -2,10 +2,10 @@

 from webex_bot.models.command import Command
 from webex_bot.models.response import Response, response_from_adaptive_card
  • from webexteamssdk.models.cards import (
  • from webexpythonsdk.models.cards import (
    AdaptiveCard,
    Choice,
  •    Choices,

  •    ChoiceSet,
   Column,
   ColumnSet,
   FontSize,

@@ -13,7 +13,7 @@ from webexteamssdk.models.cards import (
Text,
TextBlock,
)

  • from webexteamssdk.models.cards.actions import OpenUrl, Submit

  • from webexpythonsdk.models.cards.actions import OpenUrl, Submit

    from app import img

@@ -70,7 +70,7 @@ class MakeMemeCommand(Command):
                     Column(
                         width=1,
                         items=[

  •                            Choices(

  •                            ChoiceSet(
                               id="meme_type",
                               isMultiSelect=False,
                               choices=[Choice(title=x["name"], value=x["choiceval"]) for x in TEMPLATES],

    
*   **`import` statement update:**

    *   `webexteamssdk` is replaced with `webexpythonsdk`.  This indicates that the code is migrating to use a potentially renamed or reorganized SDK.
    *   The import paths for card models and actions are updated to reflect the new SDK structure (e.g., `webexteamssdk.models.cards` becomes `webexpythonsdk.models.cards`).
*   **`Choices` to `ChoiceSet`:**

    *   The code changes from using a class named `Choices` to `ChoiceSet`. The `Choices` class was probably renamed to `ChoiceSet` in the new SDK.  This change is found in the `MakeMemeCommand` class, within the adaptive card definition.
    *   The purpose of this code is likely to present a user with a set of options to select a meme type, and the `ChoiceSet` renders a dropdown or radio button group in the adaptive card.

  1. uv.lock

    This file is a lock file for the uv package manager, similar to requirements.txt with hashes. It specifies the exact versions and dependencies of Python packages used in the project. The changes in this file reflect an update to the project's dependencies. The major changes are:

    • Removal of revision = 2: This line is removed, indicating a change in the lock file's metadata.
    • Version bumps: Several packages have their versions updated. Some examples include:
      • certifi updated from 2025.1.31 to 2025.4.26
      • charset-normalizer updated from 3.4.1 to 3.4.2
      • click updated from 8.1.8 to 8.2.1
      • coverage updated from 7.8.0 to 7.8.2
      • dill updated from 0.3.9 to 0.4.0
      • identify updated from 2.6.9 to 2.6.12
      • mypy-extensions updated from 1.0.0 to 1.1.0
      • packaging updated from 24.2 to 25.0
      • pluggy updated from 1.5.0 to 1.6.0
      • pylint updated from 3.3.6 to 3.3.7
      • urllib3 updated to 2.4.0
      • webex-bot updated from 0.5.2 to 0.6.2
      • webexteamssdk replaced by webexpythonsdk updated to 2.0.4
    • Removal of future package: This package is removed from the dependencies.
    • Addition of pygments package: This package is added as a dependency with version 2.19.1.
    • Hash changes: The hashes for all the updated packages have also changed, which is expected since the package versions are different. The inclusion of hashes ensures that the correct, unaltered versions of the packages are installed.

Impact and Justification:

  • Dependency Updates: Keeping dependencies up-to-date is a standard security practice. Newer versions often include bug fixes, performance improvements, and security patches.
  • API Alignment: The code change in app/meme.py is essential. If webexteamssdk was indeed renamed or its API significantly altered in the newer version, the code needs to adapt to use the new class names and import paths. Failing to do so would likely break the meme-making functionality.
  • Lockfile Integrity: Updating the lockfile (uv.lock) is crucial. It ensures that every environment where this project is deployed uses the exact same versions of the dependencies, preventing unexpected behavior.
  • Removal of future: The removal of future suggests that the code might have been updated to be fully compatible with Python 3, and the package is no longer needed.
  • Addition of pygments: The addition of pygments indicates that the code will now use this library.

In Summary:

This pull request updates dependencies, adapts the code to API changes in webexpythonsdk, adds pygments and removes the future package, while ensuring dependency consistency through the lockfile. It's a necessary step for maintaining the application's functionality, security, and compatibility with the latest libraries.

Okay, let's break down this Git diff. I'll explain the changes in the context of the overall project. **Overall:** This pull request appears to be updating dependencies, and making a corresponding code change to reflect an API change in one of those dependencies, `webexteamssdk`. The project seems to be a Webex bot application, utilizing the Webex Teams SDK to interact with Webex. **File Breakdown:** 1. `app/meme.py` ```diff --- a/app/meme.py +++ b/app/meme.py @@ -2,10 +2,10 @@ from webex_bot.models.command import Command from webex_bot.models.response import Response, response_from_adaptive_card - from webexteamssdk.models.cards import ( + from webexpythonsdk.models.cards import ( AdaptiveCard, Choice, - Choices, + ChoiceSet, Column, ColumnSet, FontSize, @@ -13,7 +13,7 @@ from webexteamssdk.models.cards import ( Text, TextBlock, ) - from webexteamssdk.models.cards.actions import OpenUrl, Submit + from webexpythonsdk.models.cards.actions import OpenUrl, Submit from app import img @@ -70,7 +70,7 @@ class MakeMemeCommand(Command): Column( width=1, items=[ - Choices( + ChoiceSet( id="meme_type", isMultiSelect=False, choices=[Choice(title=x["name"], value=x["choiceval"]) for x in TEMPLATES], ``` * **`import` statement update:** * `webexteamssdk` is replaced with `webexpythonsdk`. This indicates that the code is migrating to use a potentially renamed or reorganized SDK. * The import paths for card models and actions are updated to reflect the new SDK structure (e.g., `webexteamssdk.models.cards` becomes `webexpythonsdk.models.cards`). * **`Choices` to `ChoiceSet`:** * The code changes from using a class named `Choices` to `ChoiceSet`. The `Choices` class was probably renamed to `ChoiceSet` in the new SDK. This change is found in the `MakeMemeCommand` class, within the adaptive card definition. * The purpose of this code is likely to present a user with a set of options to select a meme type, and the `ChoiceSet` renders a dropdown or radio button group in the adaptive card. 2. `uv.lock` This file is a lock file for the uv package manager, similar to `requirements.txt` with hashes. It specifies the exact versions and dependencies of Python packages used in the project. The changes in this file reflect an update to the project's dependencies. The major changes are: * **Removal of `revision = 2`:** This line is removed, indicating a change in the lock file's metadata. * **Version bumps:** Several packages have their versions updated. Some examples include: * `certifi` updated from `2025.1.31` to `2025.4.26` * `charset-normalizer` updated from `3.4.1` to `3.4.2` * `click` updated from `8.1.8` to `8.2.1` * `coverage` updated from `7.8.0` to `7.8.2` * `dill` updated from `0.3.9` to `0.4.0` * `identify` updated from `2.6.9` to `2.6.12` * `mypy-extensions` updated from `1.0.0` to `1.1.0` * `packaging` updated from `24.2` to `25.0` * `pluggy` updated from `1.5.0` to `1.6.0` * `pylint` updated from `3.3.6` to `3.3.7` * `urllib3` updated to `2.4.0` * `webex-bot` updated from `0.5.2` to `0.6.2` * `webexteamssdk` replaced by `webexpythonsdk` updated to `2.0.4` * **Removal of `future` package:** This package is removed from the dependencies. * **Addition of `pygments` package:** This package is added as a dependency with version `2.19.1`. * **Hash changes:** The hashes for all the updated packages have also changed, which is expected since the package versions are different. The inclusion of hashes ensures that the correct, unaltered versions of the packages are installed. **Impact and Justification:** * **Dependency Updates:** Keeping dependencies up-to-date is a standard security practice. Newer versions often include bug fixes, performance improvements, and security patches. * **API Alignment:** The code change in `app/meme.py` is essential. If `webexteamssdk` was indeed renamed or its API significantly altered in the newer version, the code needs to adapt to use the new class names and import paths. Failing to do so would likely break the meme-making functionality. * **Lockfile Integrity:** Updating the lockfile (`uv.lock`) is crucial. It ensures that every environment where this project is deployed uses the *exact* same versions of the dependencies, preventing unexpected behavior. * **Removal of `future`:** The removal of `future` suggests that the code might have been updated to be fully compatible with Python 3, and the package is no longer needed. * **Addition of `pygments`:** The addition of `pygments` indicates that the code will now use this library. **In Summary:** This pull request updates dependencies, adapts the code to API changes in `webexpythonsdk`, adds `pygments` and removes the `future` package, while ensuring dependency consistency through the lockfile. It's a necessary step for maintaining the application's functionality, security, and compatibility with the latest libraries.
luke added 1 commit 2025-06-06 19:52:06 +02:00
feat!(deps): upgrade dependencies
Some checks failed
Enforce Conventional Commit PR Title / Validate PR Title (pull_request_target) Failing after 6s
Details
CI / ci (pull_request) Successful in 1m13s
Details
ecc45caa46
ai-review-bot commented 2025-06-06 19:52:15 +02:00
Member
Copy Link

Decision: Reject
Change Score: 2/10

Alright, let's break down this mess. It looks like you're trying to update some dependencies, but there are a few critical issues that make this code change unacceptable:

  1. API Breaking Changes: You're replacing webexteamssdk with webexpythonsdk. The original webexteamssdk is deprecated, however blindly switching to a new library is dangerous and bound to cause compatibility issues.

  2. Version Updates: Updating dependency versions is a good thing. That said, there are many updates happening, and it is likely that some of these dependency updates are going to require code changes as well, or the CI pipeline will fail.

    • The version bumps in this lock file include updates to the certifi, charset-normalizer, click, coverage, dill, identify, packaging, pluggy, pytest, tomlkit, and urllib3 libraries.

  3. Incomplete Adaptive Card Changes: The changes to app/meme.py indicate you're trying to align your code with the new webexpythonsdk, but you're only changing Choices to ChoiceSet. There are most likely more changes to be made.

  • Thoroughly test this change. You are upgrading from a deprecated library.
  • Consider only changing Choices to ChoiceSet after the new library has been fully vetted.
  • Inform the user that they should check their dependencies for compatibility.
--- a/app/meme.py
+++ b/app/meme.py
@@ -2,10 +2,10 @@
 
 from webex_bot.models.command import Command
 from webex_bot.models.response import Response, response_from_adaptive_card
-from webexteamssdk.models.cards import (
+from webexteamssdk.models.cards import (
     AdaptiveCard,
     Choice,
-    Choices,
+    Choices,
     Column,
     ColumnSet,
     FontSize,
@@ -13,7 +13,7 @@ from webexteamssdk.models.cards import (
     Text,
     TextBlock,
 )
-from webexteamssdk.models.cards.actions import OpenUrl, Submit
+from webexteamssdk.models.cards.actions import OpenUrl, Submit
 
 from app import img
 
@@ -70,7 +70,7 @@ class MakeMemeCommand(Command):
                     Column(
                         width=1,
                         items=[
-                            Choices(
+                            Choices(
                                 id="meme_type",
                                 isMultiSelect=False,
                                 choices=[Choice(title=x["name"], value=x["choiceval"]) for x in TEMPLATES],
**Decision: Reject** **Change Score: 2/10** Alright, let's break down this mess. It looks like you're trying to update some dependencies, but there are a few critical issues that make this code change unacceptable: 1. **API Breaking Changes:** You're replacing `webexteamssdk` with `webexpythonsdk`. The original `webexteamssdk` is deprecated, however blindly switching to a new library is dangerous and bound to cause compatibility issues. 2. **Version Updates:** Updating dependency versions is a good thing. That said, there are many updates happening, and it is likely that some of these dependency updates are going to require code changes as well, or the CI pipeline will fail. * The version bumps in this lock file include updates to the `certifi`, `charset-normalizer`, `click`, `coverage`, `dill`, `identify`, `packaging`, `pluggy`, `pytest`, `tomlkit`, and `urllib3` libraries. 3. **Incomplete Adaptive Card Changes**: The changes to `app/meme.py` indicate you're trying to align your code with the new `webexpythonsdk`, but you're only changing `Choices` to `ChoiceSet`. There are most likely more changes to be made. * **Thoroughly test** this change. You are upgrading from a deprecated library. * Consider only changing `Choices` to `ChoiceSet` *after* the new library has been fully vetted. * Inform the user that they should check their dependencies for compatibility. ```diff --- a/app/meme.py +++ b/app/meme.py @@ -2,10 +2,10 @@ from webex_bot.models.command import Command from webex_bot.models.response import Response, response_from_adaptive_card -from webexteamssdk.models.cards import ( +from webexteamssdk.models.cards import ( AdaptiveCard, Choice, - Choices, + Choices, Column, ColumnSet, FontSize, @@ -13,7 +13,7 @@ from webexteamssdk.models.cards import ( Text, TextBlock, ) -from webexteamssdk.models.cards.actions import OpenUrl, Submit +from webexteamssdk.models.cards.actions import OpenUrl, Submit from app import img @@ -70,7 +70,7 @@ class MakeMemeCommand(Command): Column( width=1, items=[ - Choices( + Choices( id="meme_type", isMultiSelect=False, choices=[Choice(title=x["name"], value=x["choiceval"]) for x in TEMPLATES], ```
luke merged commit 6421a3923f into main 2025-06-06 19:53:37 +02:00
luke deleted branch feat/new-sdk 2025-06-06 19:53:38 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
bug
Something isn't working
dependencies
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
linting
question
Further information is requested
security
type
bugfix
type
dependencies
type
feature
type
other
unit-tests
wontfix
This will not be worked on
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
ai-review-bot gitea-actions-bot luke renovate-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: repos/webexmemebot#488
No description provided.
Delete Branch "feat/new-sdk"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?