fix(python): downgrade to latest Python 3.13 #523

luke · 2025-11-02T17:31:57Z

luke commented

2025-11-02 17:31:57 +00:00

This app's dependencies do not work with Python 3.14's new async event loop changes, so I am setting the upper version limit to 3.13.

luke added 1 commit 2025-11-02 17:31:57 +00:00

fix(python): downgrade to latest Python 3.13

Enforce Conventional Commit PR Title / Validate PR Title (pull_request_target) Successful in 3s

Details

CI / ci (pull_request) Failing after 1m8s

Details

0ebee5e324

ai-review-bot commented

2025-11-02 17:32:01 +00:00

Decision: Reject
Change Score: 2/10

I see several concerning changes in this diff. First and foremost, you're attempting to use Python 3.14, which does not exist. Stop trying to use pre-release or unreleased software. Additionally, you've downgraded the version of Python in the Dockerfile to 3.13.9, but some of the configurations are still using Python 3.14 wheels, which will cause dependency issues.

Here's what I recommend:

Revert the Python version in the Dockerfile to a released, stable version. Python 3.13 is acceptable.
Ensure that all configurations and lockfiles are consistent with the chosen Python version.
You are updating the minimum pre-commit version, this is a good idea, but you should double-check if your pre-commit hooks are compatible with this version.

I am providing the modified pyproject.toml and uv.lock files, ensure that you regenerate uv.lock after updating the Python version. You should also verify that the dependencies are compatible with the new Python version.

--- a/pyproject.toml
+++ b/pyproject.toml
@@ -6,7 +6,7 @@
 authors = [
     {name = "luketainton"},
 ]
-requires-python = ">=3.11.2"
+requires-python = "<3.14,>=3.11"
 dependencies = [
     "webex-bot<1.1.0,>=1.0.3",
     "pillow<12.0.1,>=12.0.0",

--- a/uv.lock
+++ b/uv.lock
@@ -1,6 +1,6 @@
 version = 1
 revision = 3
-requires-python = ">=3.11.2"
+requires-python = ">=3.11, <3.14"
 resolution-markers = [
     "python_full_version >= '3.12'",
     "python_full_version < '3.12'",

These changes are unacceptable until you address these critical issues.

**Decision: Reject** **Change Score: 2/10** I see several concerning changes in this diff. First and foremost, you're attempting to use Python 3.14, which does not exist. Stop trying to use pre-release or unreleased software. Additionally, you've downgraded the version of Python in the Dockerfile to 3.13.9, but some of the configurations are still using Python 3.14 wheels, which will cause dependency issues. Here's what I recommend: 1. Revert the Python version in the Dockerfile to a released, stable version. Python 3.13 is acceptable. 2. Ensure that all configurations and lockfiles are consistent with the chosen Python version. 3. You are updating the minimum pre-commit version, this is a good idea, but you should double-check if your pre-commit hooks are compatible with this version. I am providing the modified `pyproject.toml` and `uv.lock` files, ensure that you regenerate `uv.lock` after updating the Python version. You should also verify that the dependencies are compatible with the new Python version. ```diff --- a/pyproject.toml +++ b/pyproject.toml @@ -6,7 +6,7 @@ authors = [ {name = "luketainton"}, ] -requires-python = ">=3.11.2" +requires-python = "<3.14,>=3.11" dependencies = [ "webex-bot<1.1.0,>=1.0.3", "pillow<12.0.1,>=12.0.0", ``` ```diff --- a/uv.lock +++ b/uv.lock @@ -1,6 +1,6 @@ version = 1 revision = 3 -requires-python = ">=3.11.2" +requires-python = ">=3.11, <3.14" resolution-markers = [ "python_full_version >= '3.12'", "python_full_version < '3.12'", ``` These changes are unacceptable until you address these critical issues.

luke merged commit 407368dfc5 into main

2025-11-02 17:33:32 +00:00

luke referenced this issue from a commit

2025-11-02 17:33:34 +00:00

fix(python): downgrade to latest Python 3.13 (#523)

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: repos/webexmemebot#523