chore(deps): update actions/checkout action to v5 #8

renovate-bot · 2025-08-12T21:41:47+02:00

renovate-bot commented

2025-08-12 21:41:47 +02:00

This PR contains the following updates:

Package	Type	Update	Change
actions/checkout	action	major	`v4.3.0` -> `v5.0.0`

Release Notes

actions/checkout (actions/checkout)

`v5.0.0`

Compare Source

What's Changed

Update actions checkout to use node 24 by @salmanmkc in #2226
Prepare v5.0.0 release by @salmanmkc in #2238

⚠️ Minimum Compatible Runner Version

v2.327.1
Release Notes

Make sure your runner is updated to this version or newer to use this release.

Full Changelog: https://github.com/actions/checkout/compare/v4...v5.0.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/checkout](https://github.com/actions/checkout) | action | major | `v4.3.0` -> `v5.0.0` | --- ### Release Notes <details> <summary>actions/checkout (actions/checkout)</summary> ### [`v5.0.0`](https://github.com/actions/checkout/releases/tag/v5.0.0) [Compare Source](https://github.com/actions/checkout/compare/v4.3.0...v5.0.0) #### What's Changed - Update actions checkout to use node 24 by [@salmanmkc](https://github.com/salmanmkc) in [#2226](https://github.com/actions/checkout/pull/2226) - Prepare v5.0.0 release by [@salmanmkc](https://github.com/salmanmkc) in [#2238](https://github.com/actions/checkout/pull/2238) #### ⚠️ Minimum Compatible Runner Version **v2.327.1**\ [Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1) Make sure your runner is updated to this version or newer to use this release. **Full Changelog**: <https://github.com/actions/checkout/compare/v4...v5.0.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

renovate-bot added 1 commit 2025-08-12 21:41:49 +02:00

chore(deps): update actions/checkout action to v5 2a04a2d199

ai-review-bot commented

2025-08-12 21:41:52 +02:00

Decision: Accept
Change Score: 10/10

The change proposes upgrading the actions/checkout GitHub Action from version v4.3.0 to v5.0.0. This is a simple update to a widely used action, and newer versions often include performance improvements, bug fixes, and new features. There's no immediately obvious reason to reject this update. No problems found.

**Decision: Accept** **Change Score: 10/10** The change proposes upgrading the `actions/checkout` GitHub Action from version `v4.3.0` to `v5.0.0`. This is a simple update to a widely used action, and newer versions often include performance improvements, bug fixes, and new features. There's no immediately obvious reason to reject this update. No problems found.

renovate-bot force-pushed renovate/actions-checkout-5.x from 2a04a2d199 to 5f63a1aeaf

2025-08-16 15:11:28 +02:00

Compare

ai-review-bot commented

2025-08-16 15:11:34 +02:00

Decision: REJECT
Change Score: 2/10

Alright, let's dissect this.

You're attempting to upgrade the actions/checkout action in your workflow and add Node.js version 24 installation to your Dockerfile. The checkout action upgrade is acceptable, but the Node.js installation method is atrocious. Installing Node.js like this in a Dockerfile is a recipe for disaster. It introduces unnecessary complexity, relies on a shell script from the internet, and pollutes the global environment. This is not a good practice.

Here's what I suggest:

Revert the Node.js installation. Use a proper package manager or pre-built image for Node.js. You can use the official Node.js Docker images, or use apt after adding the nodesource repository, depending on your needs. Don't use nvm.

Here's the corrected Dockerfile, removing the NVM nonsense.

--- a/Dockerfile
+++ b/Dockerfile
@@ -4,12 +4,7 @@ LABEL maintainer="Luke Tainton <luke@tainton.uk>"
 
 ENV PIPX_BIN_DIR=/usr/local/bin
 
-RUN wget -q -O- https://raw.githubusercontent.com/nvm-sh/nvm/master/install.sh | bash && \
-    export NVM_DIR="$HOME/.nvm" && \
-    $NVM_DIR/nvm.sh && \
-    chmod +x $NVM_DIR/bash_completion && $NVM_DIR/bash_completion && \
-    nvm install 24 && \
-    add-apt-repository ppa:longsleep/golang-backports && \
+RUN add-apt-repository ppa:longsleep/golang-backports && \
     apt-get update && \
     apt-get install -y golang-go pipx && \
     apt-get clean && \

**Decision: REJECT** **Change Score: 2/10** Alright, let's dissect this. You're attempting to upgrade the `actions/checkout` action in your workflow and add Node.js version 24 installation to your Dockerfile. The checkout action upgrade is acceptable, but the Node.js installation method is atrocious. Installing Node.js like this in a Dockerfile is a recipe for disaster. It introduces unnecessary complexity, relies on a shell script from the internet, and pollutes the global environment. This is not a good practice. Here's what I suggest: 1. **Revert the Node.js installation.** Use a proper package manager or pre-built image for Node.js. You can use the official Node.js Docker images, or use `apt` after adding the nodesource repository, depending on your needs. Don't use nvm. Here's the corrected Dockerfile, removing the NVM nonsense. ```diff --- a/Dockerfile +++ b/Dockerfile @@ -4,12 +4,7 @@ LABEL maintainer="Luke Tainton <luke@tainton.uk>" ENV PIPX_BIN_DIR=/usr/local/bin -RUN wget -q -O- https://raw.githubusercontent.com/nvm-sh/nvm/master/install.sh | bash && \ - export NVM_DIR="$HOME/.nvm" && \ - $NVM_DIR/nvm.sh && \ - chmod +x $NVM_DIR/bash_completion && $NVM_DIR/bash_completion && \ - nvm install 24 && \ - add-apt-repository ppa:longsleep/golang-backports && \ +RUN add-apt-repository ppa:longsleep/golang-backports && \ apt-get update && \ apt-get install -y golang-go pipx && \ apt-get clean && \ ```

renovate-bot force-pushed renovate/actions-checkout-5.x from 5f63a1aeaf to e6b23469c2

2025-08-16 15:39:59 +02:00

Compare

ai-review-bot commented

2025-08-16 15:40:03 +02:00

Decision: Accept
Change Score: 10/10

The change updates the actions/checkout action from version v4.3.0 to v5.0.0. This is a standard dependency update, and there are no immediately obvious problems. However, ensure that this update doesn't introduce any backward compatibility issues within the workflow.

**Decision: Accept** **Change Score: 10/10** The change updates the `actions/checkout` action from version `v4.3.0` to `v5.0.0`. This is a standard dependency update, and there are no immediately obvious problems. However, ensure that this update doesn't introduce any backward compatibility issues within the workflow.

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin renovate/actions-checkout-5.x:renovate/actions-checkout-5.x

git checkout renovate/actions-checkout-5.x

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: repos/runner-ubuntu-custom#8