repos/roboluke
5
0
Fork 0
Code Issues 1 Pull Requests 1 Actions 1 Packages Releases 56 Activity

fix(python): update to latest Python 3.13 #389

Merged
luke merged 1 commits from 3.13 into main 2025-11-02 17:26:17 +00:00
Conversation 1 Commits 1 Files Changed 5 +5 -50
luke commented 2025-11-02 17:22:36 +00:00
Owner
Copy Link

This app's dependencies do not work with Python 3.14's new async event loop changes, so I am setting the upper version limit to 3.13.

This app's dependencies do not work with Python 3.14's new async event loop changes, so I am setting the upper version limit to 3.13.
luke added 1 commit 2025-11-02 17:22:36 +00:00
Update to latest Python 3.13
All checks were successful
Validate PR Title / validate (pull_request) Successful in 4s
Details
CI / ci (pull_request) Successful in 1m14s
Details
1d0dc8c999
ai-review-bot commented 2025-11-02 17:22:41 +00:00
Member
Copy Link

Decision: Reject
Change Score: 2/10

I am rejecting these changes. While updating the pre-commit version and renaming docker-compose.yml to compose.yaml are acceptable, the attempt to upgrade to Python 3.14 is problematic.

Python 3.14 is not a released version of Python. Attempting to use this version will lead to breakages and unexpected behavior as no such image exists. I recommend sticking with Python 3.13, and checking the dependencies for compatibility.

I am providing you with a modified pyproject.toml which should resolve this problem.

--- a/pyproject.toml
+++ b/pyproject.toml
@@ -6,7 +6,7 @@
 authors = [
     {name = "Luke Tainton", email = "luke@tainton.uk"},
 ]
-requires-python = "<4.0,>=3.11"
+requires-python = "<3.14,>=3.11"
 dependencies = [
     "webex-bot<1.1.0,>=1.0.3",
     "datetime<6.0,>=5.5",
**Decision: Reject** **Change Score: 2/10** I am rejecting these changes. While updating the pre-commit version and renaming `docker-compose.yml` to `compose.yaml` are acceptable, the attempt to upgrade to Python 3.14 is problematic. Python 3.14 is not a released version of Python. Attempting to use this version will lead to breakages and unexpected behavior as no such image exists. I recommend sticking with Python 3.13, and checking the dependencies for compatibility. I am providing you with a modified `pyproject.toml` which should resolve this problem. ```diff --- a/pyproject.toml +++ b/pyproject.toml @@ -6,7 +6,7 @@ authors = [ {name = "Luke Tainton", email = "luke@tainton.uk"}, ] -requires-python = "<4.0,>=3.11" +requires-python = "<3.14,>=3.11" dependencies = [ "webex-bot<1.1.0,>=1.0.3", "datetime<6.0,>=5.5", ```
luke changed title from Update to latest Python 3.13 to bug(python): update to latest Python 3.13 2025-11-02 17:23:41 +00:00
luke changed title from bug(python): update to latest Python 3.13 to fix(python): update to latest Python 3.13 2025-11-02 17:24:54 +00:00
luke merged commit fe1b695048 into main 2025-11-02 17:26:17 +00:00
luke deleted branch 3.13 2025-11-02 17:26:17 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 security
wontfix
This will not be worked on
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
Alexander.Lyall ai-review-bot gitea-actions-bot luke renovate-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: repos/roboluke#389
Delete Branch "3.13"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?