repos/roboluke
4
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Releases 53 Activity

feat(security): add approved rooms/users/domains as env variables #277

Merged
luketainton merged 5 commits from 276-add-approved-usersdomains-as-an-environment-variable into main 2024-08-30 18:38:57 +00:00
Conversation 2 Commits 5 Files Changed 8 +109 -28
luketainton commented 2024-08-30 18:18:38 +00:00 (Migrated from github.com)
Copy Link

Resolves #276

Resolves #276
luketainton commented 2024-08-30 18:19:12 +00:00 (Migrated from github.com)
Copy Link

Google Gemini AI Review

Decision: Reject
Change Score: 50%

  • Issue: Importing untested module

    • The code imports app.utils.helpers, but there are no tests for this module.

  • Issue: approved_users in tests

    • The test case for config contains the key approved_users, but this key is not present in the config class.

  • Issue: version in tests

    • The test case for config contains the key version, but this key is not present in the config class.

  • Issue: .env settings not used

    • The test.sh script loads .env instead of .env.test. Consequently, the test environment is not properly configured.

  • Issue: Pytest-related dependency missing

    • pytest-monkeypatch is required for testing, but it is not currently installed.

Suggestions:

  • Add tests for app.utils.helpers.
  • Remove approved_users and version from tests/test_config.py.
  • Update test.sh to load .env.test.
  • Install pytest-monkeypatch.
*Google Gemini AI Review* **Decision: Reject** **Change Score: 50%** - **Issue: Importing untested module** - The code imports `app.utils.helpers`, but there are no tests for this module. - **Issue: `approved_users` in tests** - The test case for `config` contains the key `approved_users`, but this key is not present in the `config` class. - **Issue: `version` in tests** - The test case for `config` contains the key `version`, but this key is not present in the `config` class. - **Issue: `.env` settings not used** - The `test.sh` script loads `.env` instead of `.env.test`. Consequently, the test environment is not properly configured. - **Issue: Pytest-related dependency missing** - `pytest-monkeypatch` is required for testing, but it is not currently installed. **Suggestions:** - Add tests for `app.utils.helpers`. - Remove `approved_users` and `version` from `tests/test_config.py`. - Update `test.sh` to load `.env.test`. - Install `pytest-monkeypatch`.
sonarqubecloud[bot] commented 2024-08-30 18:37:25 +00:00 (Migrated from github.com)
Copy Link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=luketainton_roboluke-tasks&pullRequest=277) **Quality Gate passed** Issues ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=luketainton_roboluke-tasks&pullRequest=277&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true) ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=luketainton_roboluke-tasks&pullRequest=277&issueStatuses=ACCEPTED) Measures ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=luketainton_roboluke-tasks&pullRequest=277&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true) ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [97.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=luketainton_roboluke-tasks&pullRequest=277&metric=new_coverage&view=list) ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=luketainton_roboluke-tasks&pullRequest=277&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=luketainton_roboluke-tasks&pullRequest=277)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
security
wontfix
This will not be worked on
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
enhancement
Milestone
No items
No Milestone
Assignees
Clear assignees
ai-review-bot gitea-actions-bot luke renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: repos/roboluke#277
No description provided.
Delete Branch "276-add-approved-usersdomains-as-an-environment-variable"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?