repos/roboluke
3
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Releases 50 Activity

Add approved users/domains as an environment variable #276

New Issue
Closed
opened 2024-08-30 19:51:21 +02:00 by kmanwar89 · 0 comments
kmanwar89 commented 2024-08-30 19:51:21 +02:00 (Migrated from github.com)
Copy Link

Using the logic here, can you add in an environment variable in Docker that allows a user to implement approved users and/or domains? This would allow non @cisco.com domains to interact with the bot.

Currently, if a non-approved domain email contacts the bot, the message is silently ignored (no output returned) and the following log appears in docker-compose:

app-1 | 2024-08-30T17:20:11.886377567Z 2024-08-30 17:20:11 [WARNING] [webex_bot.webex_bot.webex_bot.check_user_approved]:159 XXXXXXXXXXXXX@gmail.com is not approved to interact at this time. Ignoring.

The variable could be called ADDITIONAL_APPROVED_USERS and permit a comma-separate list of user ID strings and/or email addresses that can interact with the bot.

Using the logic [here](https://github.com/fbradyirl/webex_bot/blob/main/webex_bot/webex_bot.py#L87), can you add in an environment variable in Docker that allows a user to implement approved users and/or domains? This would allow non @cisco.com domains to interact with the bot. Currently, if a non-approved domain email contacts the bot, the message is silently ignored (no output returned) and the following log appears in docker-compose: `app-1 | 2024-08-30T17:20:11.886377567Z 2024-08-30 17:20:11 [WARNING] [webex_bot.webex_bot.webex_bot.check_user_approved]:159 XXXXXXXXXXXXX@gmail.com is not approved to interact at this time. Ignoring.` The variable could be called ADDITIONAL_APPROVED_USERS and permit a comma-separate list of user ID strings and/or email addresses that can interact with the bot.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
security
wontfix
This will not be worked on
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
enhancement
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: repos/roboluke#276
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?