repos/pypilot
3
0
Fork 0
Code Issues Pull Requests Actions Packages Releases 5 Activity

Added checks to ensure API responses are as expected #7

Merged
luketainton merged 3 commits from bug/ip-api-fail into main 2022-06-26 01:15:27 +02:00
Conversation 1 Commits 3 Files Changed 9 +75 -6
luketainton commented 2022-06-26 00:51:29 +02:00 (Migrated from github.com)
Copy Link
No description provided.
codecov[bot] commented 2022-06-26 00:52:01 +02:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #7 (97f4856) into main (03b85b3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           69       103   +34     
=========================================
+ Hits            69       103   +34
Impacted Files Coverage Δ
app/ip_info.py 100.00% <100.00%> (ø)
tests/test_ip_info.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03b85b3...97f4856. Read the comment docs.

# [Codecov](https://codecov.io/gh/luketainton/pypilot/pull/7?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Luke+Tainton) Report > Merging [#7](https://codecov.io/gh/luketainton/pypilot/pull/7?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Luke+Tainton) (97f4856) into [main](https://codecov.io/gh/luketainton/pypilot/commit/03b85b3befb4e6682b6d64da1c87a4e901d91ff8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Luke+Tainton) (03b85b3) will **not change** coverage. > The diff coverage is `100.00%`. ```diff @@ Coverage Diff @@ ## main #7 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 5 Lines 69 103 +34 ========================================= + Hits 69 103 +34 ``` | [Impacted Files](https://codecov.io/gh/luketainton/pypilot/pull/7?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Luke+Tainton) | Coverage Δ | | |---|---|---| | [app/ip\_info.py](https://codecov.io/gh/luketainton/pypilot/pull/7/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Luke+Tainton#diff-YXBwL2lwX2luZm8ucHk=) | `100.00% <100.00%> (ø)` | | | [tests/test\_ip\_info.py](https://codecov.io/gh/luketainton/pypilot/pull/7/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Luke+Tainton#diff-dGVzdHMvdGVzdF9pcF9pbmZvLnB5) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/luketainton/pypilot/pull/7?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Luke+Tainton). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Luke+Tainton) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/luketainton/pypilot/pull/7?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Luke+Tainton). Last update [03b85b3...97f4856](https://codecov.io/gh/luketainton/pypilot/pull/7?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Luke+Tainton). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Luke+Tainton).
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
dependencies
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
linting
python
Pull requests that update Python code
question
Further information is requested
security
unit-tests
wontfix
This will not be worked on
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: repos/pypilot#7
No description provided.
Delete Branch "bug/ip-api-fail"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?