Added checks to ensure API responses are as expected

This commit is contained in:
Luke Tainton 2022-06-25 23:50:53 +01:00
parent 03b85b3bef
commit d451d51712
No known key found for this signature in database
GPG Key ID: ABEE10849773E353
7 changed files with 30 additions and 6 deletions

View File

@ -7,6 +7,7 @@ on:
paths-ignore:
- 'README.md'
- 'LICENSE.md'
- 'CHANGELOG.md'
- '.gitignore'
- 'renovate.json'

View File

@ -7,6 +7,7 @@ on:
paths-ignore:
- 'README.md'
- 'LICENSE.md'
- 'CHANGELOG.md'
- '.gitignore'
- 'renovate.json'

View File

@ -4,6 +4,7 @@ on:
paths-ignore:
- 'README.md'
- 'LICENSE.md'
- 'CHANGELOG.md'
- '.gitignore'
- 'renovate.json'

5
CHANGELOG.md Normal file
View File

@ -0,0 +1,5 @@
# 1.1
- Added checks to ensure API responses are as expected
# 1.0
- Initial release

View File

@ -2,4 +2,4 @@
"""MODULE: Specifies app version."""
VERSION = "1.0"
VERSION = "1.1"

View File

@ -9,8 +9,13 @@ import requests
def get_ip_information(ipv4_address: ipaddress.IPv4Address) -> dict:
"""Retrieves information about a given IPv4 address from IP-API.com."""
api_endpoint = f"http://ip-api.com/json/{ipv4_address}"
resp = requests.get(api_endpoint).json()
return resp
try:
resp = requests.get(api_endpoint)
resp.raise_for_status()
ret = resp.json() if resp.json().get("status") == "success" else None
except (requests.exceptions.JSONDecodeError, requests.exceptions.HTTPError):
ret = None
return ret
def get_autonomous_system_number(as_info: str) -> str:
@ -22,7 +27,11 @@ def get_autonomous_system_number(as_info: str) -> str:
def get_prefix_information(autonomous_system: int) -> list:
"""Retrieves prefix information about a given autonomous system."""
api_endpoint = f"https://api.hackertarget.com/aslookup/?q={str(autonomous_system)}"
resp = requests.get(api_endpoint).text
prefixes = resp.split("\n")
try:
resp = requests.get(api_endpoint)
resp.raise_for_status()
except requests.exceptions.HTTPError:
return None
prefixes = resp.text.split("\n")
prefixes.pop(0)
return prefixes

View File

@ -38,6 +38,9 @@ def main():
# Get information from API
ip_info = get_ip_information(ip_address)
if not ip_info:
print("ERROR: could not retrieve IP information from API.")
sys.exit(1)
as_number = get_autonomous_system_number(ip_info.get("as"))
# Assemble list for table generation
@ -56,7 +59,11 @@ def main():
# If wanted, get prefix information
if args.prefixes:
prefix_info = get_prefix_information(as_number)
table_data.append(["Prefixes", generate_prefix_string(prefix_info)])
if not prefix_info:
print("ERROR: could not retrieve prefix information from API.")
sys.exit(1)
else:
table_data.append(["Prefixes", generate_prefix_string(prefix_info)])
print_table(table_data)