repos/docker-dnsmasq
5
0
Fork 0
Code Issues Pull Requests Actions Packages Releases 8 Activity

revert e6a196feb4 #25

Merged
luke merged 1 commits from luke-patch-1 into main 2025-10-30 20:37:25 +00:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
luke commented 2025-10-30 20:37:21 +00:00
Owner
Copy Link

revert chore(deps): update https://git.tainton.uk/actions/conventional-commits-check-action action to v1.3.0 (#23)

This PR contains the following updates:

Package Type Update Change
https://git.tainton.uk/actions/conventional-commits-check-action action minor v1.2.4 -> v1.3.0

Release Notes

actions/conventional-commits-check-action (https://git.tainton.uk/actions/conventional-commits-check-action)

v1.3.0

Compare Source

Features
  • deps: update conventional-pre-commit to 4.3.0 (b6d1665)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Reviewed-on: #23
Reviewed-by: Luke Tainton luke@tainton.uk
Co-authored-by: renovate[bot] renovate-bot@git.tainton.uk
Co-committed-by: renovate[bot] renovate-bot@git.tainton.uk

revert chore(deps): update https://git.tainton.uk/actions/conventional-commits-check-action action to v1.3.0 (#23) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [https://git.tainton.uk/actions/conventional-commits-check-action](https://git.tainton.uk/actions/conventional-commits-check-action) | action | minor | `v1.2.4` -> `v1.3.0` | --- ### Release Notes <details> <summary>actions/conventional-commits-check-action (https://git.tainton.uk/actions/conventional-commits-check-action)</summary> ### [`v1.3.0`](https://git.tainton.uk/actions/conventional-commits-check-action/releases/tag/v1.3.0) [Compare Source](https://git.tainton.uk/actions/conventional-commits-check-action/compare/v1.2.4...v1.3.0) ##### Features - **deps:** update conventional-pre-commit to 4.3.0 ([b6d1665](https://git.tainton.uk/actions/conventional-commits-check-action/commit/b6d16651374e21a51c1c1113be63c775c21287fb)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNjUuNSIsInVwZGF0ZWRJblZlciI6IjQxLjE2NS41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/repos/docker-dnsmasq/pulls/23 Reviewed-by: Luke Tainton <luke@tainton.uk> Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk> Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
luke added 1 commit 2025-10-30 20:37:21 +00:00
revert e6a196feb4
Some checks failed
Validate PR Title / validate (pull_request) Failing after 2s
Details
CI / ci (pull_request) Successful in 7s
Details
8eddd75222 
revert chore(deps): update https://git.tainton.uk/actions/conventional-commits-check-action action to v1.3.0 (#23)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [https://git.tainton.uk/actions/conventional-commits-check-action](https://git.tainton.uk/actions/conventional-commits-check-action) | action | minor | `v1.2.4` -> `v1.3.0` |

---

### Release Notes

<details>
<summary>actions/conventional-commits-check-action (https://git.tainton.uk/actions/conventional-commits-check-action)</summary>

### [`v1.3.0`](https://git.tainton.uk/actions/conventional-commits-check-action/releases/tag/v1.3.0)

[Compare Source](https://git.tainton.uk/actions/conventional-commits-check-action/compare/v1.2.4...v1.3.0)

##### Features

- **deps:** update conventional-pre-commit to 4.3.0 ([b6d1665](b6d1665137))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNjUuNSIsInVwZGF0ZWRJblZlciI6IjQxLjE2NS41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->

Reviewed-on: #23
Reviewed-by: Luke Tainton <luke@tainton.uk>
Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk>
Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
luke merged commit 0292d3b27f into main 2025-10-30 20:37:25 +00:00
luke deleted branch luke-patch-1 2025-10-30 20:37:25 +00:00
ai-review-bot commented 2025-10-30 20:37:30 +00:00
Member
Copy Link

Decision: Reject
Change Score: 2/10

This change proposes downgrading the version of the conventional-commits-check-action used in the workflow. Downgrading actions is generally a bad idea unless there's a very specific and well-understood reason (e.g., a critical bug in the newer version that affects you, and that is not the case here). You're moving from v1.3.0 to v1.2.4, which likely includes bug fixes, improvements, and possibly even security patches that you would be missing out on. This is almost certainly not the right approach, and I strongly advise against it unless you have a concrete justification. Sticking to newer versions is almost always preferable, especially within the same major version, since you're likely to receive security patches and bug fixes.

If there is a problem that v1.3.0 causes for you, you should detail it in the commit message and the review request, so that it can be evaluated.

I am rejecting this change.

**Decision: Reject** **Change Score: 2/10** This change proposes downgrading the version of the `conventional-commits-check-action` used in the workflow. Downgrading actions is generally a bad idea unless there's a very specific and well-understood reason (e.g., a critical bug in the newer version that affects you, and that is not the case here). You're moving from v1.3.0 to v1.2.4, which likely includes bug fixes, improvements, and possibly even security patches that you would be missing out on. This is almost certainly not the right approach, and I strongly advise against it unless you have a concrete justification. Sticking to newer versions is almost always preferable, especially within the same major version, since you're likely to receive security patches and bug fixes. If there is a problem that v1.3.0 causes for you, you should detail it in the commit message and the review request, so that it can be evaluated. I am rejecting this change.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
Alexander.Lyall ai-review-bot gitea-actions-bot luke renovate-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: repos/docker-dnsmasq#25
Delete Branch "luke-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?