public/roboluke-tasks
3
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Releases 48 Activity

BUG: Handle empty or undefined environment variables for approved users/rooms/domains #278

New Issue
Closed
opened 2024-08-30 21:29:33 +02:00 by kmanwar89 · 0 comments
kmanwar89 commented 2024-08-30 21:29:33 +02:00 (Migrated from github.com)
Copy Link

Fixing #277 in v1.14.0 has uncovered new (unexpected) behavior in the three new environment variables have been added:

  • APPROVED_USERS
  • APPROVED_DOMAINS
  • APPROVED_ROOMS

If only one of these is defined, the following error is seen in the docker compose logs, and the bot fails:

app-1 | 2024-08-30T18:47:37.527585720Z 2024-08-30 18:47:37 [WARNING] [webex_bot.webex_bot.webex_bot.is_user_member_of_room]:172 API error: [404] Not Found - The requested resource could not be found. [Tracking ID: ROUTERGW_fbe6ecd2-d0f3-4cbb-afeb-40032a1c17f6]

This can be fixed one of two ways:

  1. Update documentation to state that all 3 entries are required even if they are blank
  2. Write logic that handles a blank/undefined environment variable
Fixing #277 in v1.14.0 has uncovered new (unexpected) behavior in the three new environment variables have been added: * APPROVED_USERS * APPROVED_DOMAINS * APPROVED_ROOMS If only one of these is defined, the following error is seen in the docker compose logs, and the bot fails: `app-1 | 2024-08-30T18:47:37.527585720Z 2024-08-30 18:47:37 [WARNING] [webex_bot.webex_bot.webex_bot.is_user_member_of_room]:172 API error: [404] Not Found - The requested resource could not be found. [Tracking ID: ROUTERGW_fbe6ecd2-d0f3-4cbb-afeb-40032a1c17f6]` This can be fixed one of two ways: 1. Update documentation to state that all 3 entries are required *even if they are blank* 2. Write logic that handles a blank/undefined environment variable
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
security

   
wontfix

This will not be worked on

No Label
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: public/roboluke-tasks#278
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?