mirror of
https://github.com/grdl/git-get.git
synced 2026-02-04 15:39:46 +00:00
Fix issues found by testifylint linter
This commit is contained in:
@@ -1,7 +1,6 @@
|
||||
package git
|
||||
|
||||
import (
|
||||
"errors"
|
||||
"git-get/pkg/git/test"
|
||||
"os"
|
||||
"testing"
|
||||
@@ -67,7 +66,7 @@ func TestExists(t *testing.T) {
|
||||
t.Run(test.name, func(t *testing.T) {
|
||||
_, err := Exists(test.path)
|
||||
|
||||
assert.True(t, errors.Is(err, test.want))
|
||||
assert.ErrorIs(t, err, test.want)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
@@ -5,6 +5,7 @@ import (
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
// Following URLs are considered valid according to https://git-scm.com/docs/git-clone#_git_urls:
|
||||
@@ -53,7 +54,7 @@ func TestURLParse(t *testing.T) {
|
||||
|
||||
for _, test := range tests {
|
||||
url, err := ParseURL(test.in, cfg.Defaults[cfg.KeyDefaultHost], cfg.Defaults[cfg.KeyDefaultScheme])
|
||||
assert.NoError(t, err)
|
||||
require.NoError(t, err)
|
||||
|
||||
got := URLToPath(*url, false)
|
||||
assert.Equal(t, test.want, got)
|
||||
@@ -93,7 +94,7 @@ func TestURLParseSkipHost(t *testing.T) {
|
||||
|
||||
for _, test := range tests {
|
||||
url, err := ParseURL(test.in, cfg.Defaults[cfg.KeyDefaultHost], cfg.Defaults[cfg.KeyDefaultScheme])
|
||||
assert.NoError(t, err)
|
||||
require.NoError(t, err)
|
||||
|
||||
got := URLToPath(*url, true)
|
||||
assert.Equal(t, test.want, got)
|
||||
@@ -119,12 +120,12 @@ func TestDefaultScheme(t *testing.T) {
|
||||
|
||||
for _, test := range tests {
|
||||
url, err := ParseURL(test.in, cfg.Defaults[cfg.KeyDefaultHost], test.scheme)
|
||||
assert.NoError(t, err)
|
||||
require.NoError(t, err)
|
||||
|
||||
want, err := url.Parse(test.want)
|
||||
assert.NoError(t, err)
|
||||
require.NoError(t, err)
|
||||
|
||||
assert.Equal(t, url, want)
|
||||
assert.Equal(t, want, url)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user