From c9a5539670d8e8dee77967f76cdf26c133dc515d Mon Sep 17 00:00:00 2001 From: Grzegorz Dlugoszewski Date: Sun, 24 Aug 2025 17:28:21 +0200 Subject: [PATCH] Fix issues found by testifylint linter --- pkg/git/finder_test.go | 3 +-- pkg/url_test.go | 11 ++++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/pkg/git/finder_test.go b/pkg/git/finder_test.go index 62d5d71..e5d1b14 100644 --- a/pkg/git/finder_test.go +++ b/pkg/git/finder_test.go @@ -1,7 +1,6 @@ package git import ( - "errors" "git-get/pkg/git/test" "os" "testing" @@ -67,7 +66,7 @@ func TestExists(t *testing.T) { t.Run(test.name, func(t *testing.T) { _, err := Exists(test.path) - assert.True(t, errors.Is(err, test.want)) + assert.ErrorIs(t, err, test.want) }) } } diff --git a/pkg/url_test.go b/pkg/url_test.go index 8bccd87..f9a6700 100644 --- a/pkg/url_test.go +++ b/pkg/url_test.go @@ -5,6 +5,7 @@ import ( "testing" "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" ) // Following URLs are considered valid according to https://git-scm.com/docs/git-clone#_git_urls: @@ -53,7 +54,7 @@ func TestURLParse(t *testing.T) { for _, test := range tests { url, err := ParseURL(test.in, cfg.Defaults[cfg.KeyDefaultHost], cfg.Defaults[cfg.KeyDefaultScheme]) - assert.NoError(t, err) + require.NoError(t, err) got := URLToPath(*url, false) assert.Equal(t, test.want, got) @@ -93,7 +94,7 @@ func TestURLParseSkipHost(t *testing.T) { for _, test := range tests { url, err := ParseURL(test.in, cfg.Defaults[cfg.KeyDefaultHost], cfg.Defaults[cfg.KeyDefaultScheme]) - assert.NoError(t, err) + require.NoError(t, err) got := URLToPath(*url, true) assert.Equal(t, test.want, got) @@ -119,12 +120,12 @@ func TestDefaultScheme(t *testing.T) { for _, test := range tests { url, err := ParseURL(test.in, cfg.Defaults[cfg.KeyDefaultHost], test.scheme) - assert.NoError(t, err) + require.NoError(t, err) want, err := url.Parse(test.want) - assert.NoError(t, err) + require.NoError(t, err) - assert.Equal(t, url, want) + assert.Equal(t, want, url) } }