mirrors/git-get
6
0
Fork 0
mirror of https://github.com/grdl/git-get.git synced 2026-02-04 22:04:41 +00:00
Code Activity

Add URL parsing function and its unit tests

Browse Source
This commit is contained in:
Grzegorz Dlugoszewski
2020-05-21 22:48:28 +02:00
parent 91cf26ef27
commit bb3a243829
2 changed files with 91 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
pkg/url.go Normal file
View File

@@ -0,0 +1,28 @@
package pkg
import (
"net/url"
"path"
"strings"
"github.com/pkg/errors"
)
// TODO: maybe use https://github.com/whilp/git-urls?
func URLToPath(rawurl string) (string, error) {
parsed, err := url.Parse(rawurl)
if err != nil {
return "", errors.Wrap(err, "Failed parsing URL")
}
repoHost := strings.Split(parsed.Host, ":")[0]
repoPath := parsed.Path
//repoPath = strings.TrimSuffix(repoPath, ".git/")
//repoPath = strings.TrimSuffix(repoPath, ".git")
localPath := path.Join(repoHost, repoPath)
localPath = strings.TrimSuffix(localPath, ".git")
return localPath, nil
}

63
pkg/url_test.go Normal file
View File

@@ -0,0 +1,63 @@
package pkg
import "testing"
// Following URLs are considered valid according to https://git-scm.com/docs/git-clone#_git_urls:
// ssh://[user@]host.xz[:port]/path/to/repo.git
// ssh://[user@]host.xz[:port]/~[user]/path/to/repo.git/
// [user@]host.xz:path/to/repo.git/
// [user@]host.xz:/~[user]/path/to/repo.git/
// git://host.xz[:port]/path/to/repo.git/
// git://host.xz[:port]/~[user]/path/to/repo.git/
// http[s]://host.xz[:port]/path/to/repo.git/
// ftp[s]://host.xz[:port]/path/to/repo.git/
// /path/to/repo.git/
// file:///path/to/repo.git/
func TestURLParse(t *testing.T) {
tests := []struct {
in string
want string
}{
{"ssh://github.com/grdl/git-get.git", "github.com/grdl/git-get"},
{"ssh://user@github.com/grdl/git-get.git", "github.com/grdl/git-get"},
{"ssh://user@github.com/~user/grdl/git-get.git", "github.com/~user/grdl/git-get"}, // TODO: is this what we want or should the result be github.com/grdl/git-get?
{"git@github.com:grdl/git-get.git", "github.com/grdl/git-get"},
{"git@github.com:/~user/grdl/git-get.git", "github.com/grdl/git-get"},
{"https://github.com/grdl/git-get.git", "github.com/grdl/git-get"},
{"https://github.com/grdl/git-get.git", "github.com/grdl/git-get"},
{"https://github.com/grdl/git-get.git", "github.com/grdl/git-get"},
{"https://github.com/grdl/git-get.git", "github.com/grdl/git-get"},
{"https://github.com/grdl/git-get.git", "github.com/grdl/git-get"},
{"http://github.com/grdl/git-get.git", "github.com/grdl/git-get"},
{"https://github.com/grdl/git-get", "github.com/grdl/git-get"},
{"https://github.com/git-get.git", "github.com/git-get"},
{"https://github.com/git-get", "github.com/git-get"},
{"https://github.com/grdl/sub/path/git-get.git", "github.com/grdl/sub/path/git-get"},
{"https://github.com:1234/grdl/git-get.git", "github.com/grdl/git-get"},
{"https://github.com/grdl/git-get.git/", "github.com/grdl/git-get"},
{"https://github.com/grdl/git-get/", "github.com/grdl/git-get"},
{"https://github.com/grdl/git-get/////", "github.com/grdl/git-get"},
{"https://github.com/grdl/git-get.git/////", "github.com/grdl/git-get"},
{"local/grdl/git-get/", "local/grdl/git-get"},
{"file://local/grdl/git-get", "local/grdl/git-get"},
{"https://github.com/grdl/git-get/////", "github.com/grdl/git-get"},
{"https://github.com/grdl/git-get/////", "github.com/grdl/git-get"},
{"https://github.com/grdl/git-get/////", "github.com/grdl/git-get"},
}
for _, test := range tests {
got, err := URLToPath(test.in)
if err != nil {
t.Errorf("Error parsing URL: %+v", err)
}
if got != test.want {
t.Errorf("Wrong result of parsing URL: %s, got: %s; want: %s", test.in, got, test.want)
}
}
}