1
0
mirror of https://github.com/tw93/Mole.git synced 2026-02-04 14:26:46 +00:00

fix(windows): address code review issues

- Fix openInExplorer to actually execute explorer.exe (was a no-op)
- Load System.Windows.Forms assembly before using Clipboard
- Use Remove-SafeItem in purge for consistent safety checks
- Fix Dropbox typo (was DroplboxCache)
This commit is contained in:
Bhadra
2026-01-08 20:08:41 +05:30
parent 34affd75c4
commit cfe8ea0724
4 changed files with 13 additions and 21 deletions

View File

@@ -473,20 +473,16 @@ function Remove-ProjectArtifacts {
foreach ($artifact in $project.Artifacts) {
if (Test-Path $artifact.Path) {
try {
if ($artifact.Type -eq "Directory") {
Remove-Item -Path $artifact.Path -Recurse -Force -ErrorAction Stop
}
else {
Remove-Item -Path $artifact.Path -Force -ErrorAction Stop
}
# Use safe removal with protection checks
$result = Remove-SafeItem -Path $artifact.Path -Description $artifact.Name -Recurse
if ($result.Removed -gt 0) {
Write-Host " $esc[32m$($script:Icons.Success)$esc[0m $($artifact.Name) ($($artifact.SizeHuman))"
$script:TotalSizeCleaned += $artifact.SizeKB
$script:ItemsCleaned++
}
catch {
Write-Host " $esc[31m$($script:Icons.Error)$esc[0m $($artifact.Name) - $_"
elseif ($result.Failed -gt 0) {
Write-Host " $esc[31m$($script:Icons.Error)$esc[0m $($artifact.Name) - removal failed"
}
}
}

View File

@@ -7,6 +7,7 @@ import (
"flag"
"fmt"
"os"
"os/exec"
"path/filepath"
"runtime"
"sort"
@@ -671,19 +672,11 @@ func truncatePath(path string, maxLen int) string {
// openInExplorer opens a path in Windows Explorer
func openInExplorer(path string) {
// Use explorer.exe to open the path
cmd := fmt.Sprintf("explorer.exe /select,\"%s\"", path)
go func() {
_ = runCommand("cmd", "/c", cmd)
exec.Command("explorer.exe", "/select,", path).Run()
}()
}
// runCommand runs a command and returns the output
func runCommand(name string, args ...string) error {
cmd := fmt.Sprintf("%s %s", name, strings.Join(args, " "))
_ = cmd
return nil
}
func main() {
var startPath string

View File

@@ -207,7 +207,7 @@ function Clear-OneDriveCache {
}
}
function Clear-DroplboxCache {
function Clear-DropboxCache {
<#
.SYNOPSIS
Clean Dropbox cache
@@ -405,7 +405,7 @@ function Invoke-AppCleanup {
# Productivity apps
Clear-OfficeCache
Clear-OneDriveCache
Clear-DroplboxCache
Clear-DropboxCache
Clear-GoogleDriveCache
# Creative apps

View File

@@ -289,6 +289,9 @@ function Clear-ClipboardHistory {
}
try {
# Load Windows Forms assembly for clipboard access
Add-Type -AssemblyName System.Windows.Forms -ErrorAction SilentlyContinue
# Clear current clipboard
[System.Windows.Forms.Clipboard]::Clear()