archives/FHeD
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases 40 Activity

Add update/close ability to tickets #38

Merged
luketainton merged 8 commits from feature/issue-5 into main 2020-08-09 13:04:44 +00:00
Conversation 10 Commits 8 Files Changed 5 +449 -40
luketainton commented 2020-08-09 12:25:38 +00:00 (Migrated from github.com)
Copy Link

Closes #5

Closes #5
luketainton commented 2020-08-09 12:26:09 +00:00 (Migrated from github.com)
Copy Link

UI now looks like this:

image

UI now looks like this: ![image](https://user-images.githubusercontent.com/22561713/89732047-d934c680-da43-11ea-9a08-c42af4429c2d.png)
MrLyallCSIT commented 2020-08-09 12:30:17 +00:00 (Migrated from github.com)
Copy Link

Does the back end work for updates now?

Does the back end work for updates now?
MrLyallCSIT (Migrated from github.com) reviewed 2020-08-09 12:31:49 +00:00
app/includes/header.php
MrLyallCSIT (Migrated from github.com) commented 2020-08-09 12:31:49 +00:00
Copy Link

Why is favicon deleted?

Why is favicon deleted?
MrLyallCSIT (Migrated from github.com) requested changes 2020-08-09 12:33:02 +00:00
MrLyallCSIT (Migrated from github.com) left a comment
Copy Link

This does not complete the requirements of the original issue

This does not complete the requirements of the original issue
luketainton (Migrated from github.com) reviewed 2020-08-09 12:38:51 +00:00
app/includes/header.php
luketainton (Migrated from github.com) commented 2020-08-09 12:38:51 +00:00
Copy Link

Good catch - no idea why this happened.

Good catch - no idea why this happened.
luketainton commented 2020-08-09 12:40:35 +00:00 (Migrated from github.com)
Copy Link

Does the back end work for updates now?

I must be having a bad day, no it isn't. update.php is currently an exact clone of what view.php used to be, so this needs fixing.

> Does the back end work for updates now? I must be having a bad day, no it isn't. update.php is currently an exact clone of what view.php used to be, so this needs fixing.
MrLyallCSIT commented 2020-08-09 12:41:32 +00:00 (Migrated from github.com)
Copy Link

Does the back end work for updates now?

I must be having a bad day, no it isn't. update.php is currently an exact clone of what view.php used to be, so this needs fixing.

Want me to upload the original I uploaded?

> > Does the back end work for updates now? > > I must be having a bad day, no it isn't. update.php is currently an exact clone of what view.php used to be, so this needs fixing. Want me to upload the original I uploaded?
luketainton commented 2020-08-09 12:42:22 +00:00 (Migrated from github.com)
Copy Link

Want me to upload the original I uploaded?

Yes please. Either on the branch or as a copy/paste, I don't mind 😄

> Want me to upload the original I uploaded? Yes please. Either on the branch or as a copy/paste, I don't mind 😄
MrLyallCSIT commented 2020-08-09 12:45:54 +00:00 (Migrated from github.com)
Copy Link

Want me to upload the original I uploaded?

Yes please. Either on the branch or as a copy/paste, I don't mind 😄

Fixing now. should be a new commit showing up shortly

> > Want me to upload the original I uploaded? > > Yes please. Either on the branch or as a copy/paste, I don't mind 😄 Fixing now. should be a new commit showing up shortly
MrLyallCSIT (Migrated from github.com) approved these changes 2020-08-09 13:04:26 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
luketainton
MrLyallCSIT
Labels
Clear labels
dependencies
Pull requests that update a dependency file
 release:major
Auto Version - Major release
 release:minor
Auto Version - Minor release
 release:patch
Auto Version - Patch release
 status:duplicate
This issue or pull request already exists
 status:stale
Auto-closed due to inactivity
 type:bug
Something isn't working
 type:docs
Improvements or additions to documentation
 type:epic
Major/breaking changes to the codebase
 type:feature
New feature or request
 type:question
Further information is requested
No Label type:feature
Milestone
No items
No Milestone
Assignees
Clear assignees
luke
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: archives/FHeD#38
Delete Branch "feature/issue-5"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?