archives/FHeD
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases 40 Activity

🐛 User not added to DB - force die() on error #118

Merged
luketainton merged 2 commits from bug-69 into main 2020-08-17 15:17:07 +00:00
Conversation 1 Commits 2 Files Changed 2 +51 -41
luketainton commented 2020-08-17 14:44:53 +00:00 (Migrated from github.com)
Copy Link

Description

This PR ensures that any errors with the login flow are caught.
Related to #69

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes the documentation (README.md).
## Description This PR ensures that any errors with the login flow are caught. Related to #69 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist: - [x] I read & comply with the [contributing guidelines](https://github.com/luketainton/FHeD/blob/main/.github/CONTRIBUTING.md) - [x] I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers. - [x] I have made corresponding changes the documentation (README.md).
MrLyallCSIT (Migrated from github.com) approved these changes 2020-08-17 15:17:02 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
MrLyallCSIT
Labels
Clear labels
dependencies
Pull requests that update a dependency file
 release:major
Auto Version - Major release
 release:minor
Auto Version - Minor release
 release:patch
Auto Version - Patch release
 status:duplicate
This issue or pull request already exists
 status:stale
Auto-closed due to inactivity
 type:bug
Something isn't working
 type:docs
Improvements or additions to documentation
 type:epic
Major/breaking changes to the codebase
 type:feature
New feature or request
 type:question
Further information is requested
No Label release:patch type:bug
Milestone
No items
No Milestone
Assignees
Clear assignees
luke
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: archives/FHeD#118
Delete Branch "bug-69"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?