repos/webexmemebot
4
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Releases 46 Activity
533 Commits 1 Branch 46 Tags
7ab6178861c818e0e0571c784b4b6f78e48c5114
Commit Graph

15 Commits

Author SHA1 Message Date
Luke Tainton
13097b36fb fix(lint): Fix linting issues (#487)
Some checks failed
Security / sonarqube (push) Failing after 36s
Details
Security / snyk (push) Successful in 1m1s
Details 
This pull request focuses on improving the documentation and readability of the Webex meme bot application by adding docstrings and minor formatting adjustments. Here's a breakdown of the changes:

*   **Docstrings:**
    *   Added module-level docstrings to `app/close.py`, `app/img.py`, and `app/main.py` providing a high-level overview of the purpose of each module.
    *   Added docstrings to classes (`ExitCommand`, `MakeMemeCommand`, `MakeMemeCallback`) describing their role.
    *   Added docstrings to methods within those classes (`__init__`, `pre_execute`, `execute`, `post_execute`) explaining their functionality, arguments, and return values where applicable. The `get_templates` and `format_meme_string` functions in `app/img.py` have been documented as well.
*   **Formatting:**
    *   Added a line break before the return type annotation in function definitions (e.g., `def execute(...) -> Response:`).
    *   Added the disable comment `# pylint: disable=line-too-long` to a line in `app/meme.py` to disable pylint for that line.
    *   Added the disable comment `# pylint: disable=unused-argument` to the `pre_execute`, `execute`, and `post_execute` methods to disable pylint checks about unused arguments. This is because these methods are part of an interface and must have the same signature even if some arguments are unused.
*   **Variable Naming:**
    *   Renamed the `vars` dictionary to `env_vars` in `tests/test_config.py` for better clarity.
*   **Test Update:**
    *   Added a docstring to the `test_config` function in `tests/test_config.py` to explain its functionality.
*   **Imports Update:**
    *   Updated imports in `tests/test_config.py` to disable pylint for wrong-import-position errors using `# pylint: disable=wrong-import-position`.

In essence, these changes enhance the maintainability and understandability of the codebase through comprehensive documentation and minor code style improvements.

Reviewed-on: #487
 2025-06-06 19:39:11 +02:00
Luke Tainton
590e0941bf Update .gitea/workflows/ci.yml
Some checks failed
Security / sonarqube (push) Failing after 35s
Details
Security / snyk (push) Successful in 1m1s
Details
2025-06-06 19:20:14 +02:00
Luke Tainton
29e597c815 Update .gitea/workflows/ci.yml
Some checks failed
Security / sonarqube (push) Failing after 32s
Details
Security / snyk (push) Successful in 1m13s
Details
2025-06-06 19:19:38 +02:00
Luke Tainton
4c51e697d9 Update .gitea/workflows/ci.yml
Some checks failed
Security / sonarqube (push) Failing after 31s
Details
Security / snyk (push) Successful in 1m0s
Details
2025-06-06 19:15:51 +02:00
Renovate [BOT]
0aecbae7d6 chore(deps): update sonarsource/sonarqube-scan-action action to v5.2.0 (#480)
All checks were successful
Security / sonarqube (push) Successful in 10m54s
Details
Security / snyk (push) Successful in 13m44s
Details 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [SonarSource/sonarqube-scan-action](https://github.com/SonarSource/sonarqube-scan-action) | action | minor | `v5.1.0` -> `v5.2.0` |

---

### Release Notes

<details>
<summary>SonarSource/sonarqube-scan-action (SonarSource/sonarqube-scan-action)</summary>

### [`v5.2.0`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v5.2.0)

[Compare Source](https://github.com/SonarSource/sonarqube-scan-action/compare/v5.1.0...v5.2.0)

##### What's Changed

-   SQSCANGHA-90 remove mend dead conf by [@&#8203;pierre-guillot-gh](https://github.com/pierre-guillot-gh) in https://github.com/SonarSource/sonarqube-scan-action/pull/184
-   SQSCANGHA-89 Attempt to fix command injection by [@&#8203;henryju](https://github.com/henryju) in https://github.com/SonarSource/sonarqube-scan-action/pull/186
-   SQSCANGHA-93 Fix madhead/semver-utils' version by [@&#8203;csaba-feher-sonarsource](https://github.com/csaba-feher-sonarsource) in https://github.com/SonarSource/sonarqube-scan-action/pull/187
-   SQSCANGHA-94 Update version update logic by [@&#8203;csaba-feher-sonarsource](https://github.com/csaba-feher-sonarsource) in https://github.com/SonarSource/sonarqube-scan-action/pull/188
-   SQSCANGHA-92 Validate scanner version by [@&#8203;csaba-feher-sonarsource](https://github.com/csaba-feher-sonarsource) in https://github.com/SonarSource/sonarqube-scan-action/pull/189

**Full Changelog**: https://github.com/SonarSource/sonarqube-scan-action/compare/v5...v5.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC43LjAiLCJ1cGRhdGVkSW5WZXIiOiI0MC43LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInR5cGUvZGVwZW5kZW5jaWVzIl19-->

Reviewed-on: #480
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
 2025-05-07 20:49:55 +02:00
Renovate [BOT]
e54838e6ac chore(deps): update sonarsource/sonarqube-scan-action action to v5.1.0 (#476)
Some checks failed
Release / Manual Trigger Cleanup (push) Has been skipped
Details
Release / Create Release (push) Successful in 19s
Details
Release / Build Docker Images (push) Failing after 1m57s
Details
Security / sonarqube (push) Successful in 2m5s
Details
Security / snyk (push) Successful in 3m14s
Details 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [SonarSource/sonarqube-scan-action](https://github.com/SonarSource/sonarqube-scan-action) | action | minor | `v5.0.0` -> `v5.1.0` |

---

### Release Notes

<details>
<summary>SonarSource/sonarqube-scan-action (SonarSource/sonarqube-scan-action)</summary>

### [`v5.1.0`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v5.1.0)

[Compare Source](https://github.com/SonarSource/sonarqube-scan-action/compare/v5.0.0...v5.1.0)

##### What's Changed

-   Update SonarScanner CLI to 7.1.0.4889 to support sonar.region=us by [@&#8203;github-actions](https://github.com/github-actions) in https://github.com/SonarSource/sonarqube-scan-action/pull/183

**Full Changelog**: https://github.com/SonarSource/sonarqube-scan-action/compare/v5.0.0...v5.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMTEuNCIsInVwZGF0ZWRJblZlciI6IjM5LjIxMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->

Reviewed-on: #476
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
 2025-03-24 19:18:27 +01:00
Renovate [BOT]
1122726fc9 chore(deps): update sonarsource/sonarqube-scan-action action to v5 (#470)
All checks were successful
Security / sonarqube (push) Successful in 4m6s
Details
Security / snyk (push) Successful in 4m55s
Details 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [SonarSource/sonarqube-scan-action](https://github.com/SonarSource/sonarqube-scan-action) | action | major | `v4.2.1` -> `v5.0.0` |

---

### Release Notes

<details>
<summary>SonarSource/sonarqube-scan-action (SonarSource/sonarqube-scan-action)</summary>

### [`v5.0.0`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v5.0.0)

[Compare Source](https://github.com/SonarSource/sonarqube-scan-action/compare/v4.2.1...v5.0.0)

#### What's Changed

-   SQSCANGHA-81 Update SonarScanner CLI to 7.0.2.4839 by [@&#8203;github-actions](https://github.com/github-actions) in https://github.com/SonarSource/sonarqube-scan-action/pull/175

**Full Changelog**: https://github.com/SonarSource/sonarqube-scan-action/compare/v4...v5.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNzEuMyIsInVwZGF0ZWRJblZlciI6IjM5LjE3MS4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->

Reviewed-on: #470
Reviewed-by: Luke Tainton <luke@tainton.uk>
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
 2025-02-17 12:02:39 +01:00
Luke Tainton
44d6f9d161 feat(ci): fix CI, switch to self-hosted SonarQube
All checks were successful
Enforce Conventional Commit PR Title / Validate PR Title (pull_request_target) Successful in 5s
Details
CI / ci (pull_request) Successful in 1m29s
Details
Security / sonarqube (push) Successful in 3m9s
Details
Security / snyk (push) Successful in 4m25s
Details
2025-02-09 20:38:33 +00:00
Luke Tainton
7fa0955d23 fix(ci): switch poetry to uv
All checks were successful
Enforce Conventional Commit PR Title / Validate PR Title (pull_request) Successful in 3s
Details
CI / ci (pull_request) Successful in 2m11s
Details
2025-01-03 16:46:00 +00:00
Luke Tainton
2a5f074002 feat: switch to uv
Some checks failed
Enforce Conventional Commit PR Title / Validate PR Title (pull_request) Successful in 3s
Details
CI / ci (pull_request) Failing after 17s
Details
2025-01-03 16:41:14 +00:00
Luke Tainton
d3fab75acb fix(ci): correct name of CI to match branch protection rules 2025-01-02 18:43:23 +00:00
Luke Tainton
e9722d55b1 fix(ci): fix constantly failing CI (#450) 
Reviewed-on: public/webexmemebot#450
 2025-01-02 18:05:15 +01:00
Renovate [BOT]
1ee8896ee4 chore(deps): update actions/checkout action to v4.2.2
Some checks are pending
CI / ci (pull_request) Waiting to run
Details
2025-01-01 03:18:14 +00:00
Luke Tainton
8ccd60219f feat(ci): cache dependencies 2025-01-01 01:16:43 +00:00
Luke Tainton
339e8343d2 chore(ci): migrate SOT to Gitea (#429) 
Reviewed-on: public/webexmemebot#429
 2025-01-01 00:17:19 +01:00