fix(ci): fix release workflow #351

luke · 2025-05-10T21:52:26+02:00

luke commented

2025-05-10 21:52:26 +02:00

No description provided.

luke added 1 commit 2025-05-10 21:52:29 +02:00

fix(ci): fix release workflow

Validate PR Title / validate (pull_request) Successful in 17s

Details

CI / ci (pull_request) Successful in 4m38s

Details

401c2d44df

ai-review-bot commented

2025-05-10 21:52:38 +02:00

Decision: Reject
Change Score: 2/10

This diff is a mess! It's full of commented-out code, commented-out jobs, and generally looks like someone was experimenting without cleaning up afterward. The changes lack a clear purpose and introduce unnecessary complexity. This is a step backward, not forward.

Here's a breakdown of the issues and suggested fixes:

Commenting out CI job: Removing the CI job is a bad idea. CI is crucial for ensuring code quality and preventing regressions. Revert this change.
Commenting out get_release_id and publish_pypi jobs: Why are these jobs being disabled? Understand the reason and either fix the underlying issue or remove the jobs entirely if they are truly obsolete. Don't just comment them out.
Inconsistent commenting styles: Some sections are fully commented out, while others have individual lines commented out. Be consistent. Choose one approach and stick to it.
General cleanup needed: Remove all the commented-out code and jobs. It clutters the workflow and makes it harder to understand. If you're not using it, delete it.
Missing Dependencies: The create_docker job depends on create_release, not tag.

I strongly suggest you revert these changes, clean up the workflow file, and then resubmit with a clear explanation of the intended changes and their benefits. Before even thinking of submitting this code, run the workflow locally to check if it works.

name: Release
on:
  workflow_dispatch:
  schedule:
    - cron: '0 9 * * 0'

jobs:
  tag:
    name: Tag release
    runs-on: ubuntu-latest
    outputs:
      tag_name: ${{ steps.tag_release.outputs.tag_name }}
    steps:
      - name: Checkout code
        uses: actions/checkout@v4
        with:
          fetch-depth: 0
      - name: Bump version and create tag
        id: tag_release
        uses: anothrNick/github-tag-action@1.66.0
        env:
          GITHUB_TOKEN: ${{ secrets.ACTIONS_TOKEN }}
          DEFAULT_BUMP: patch
          WITH_V: true
          RELEASE_BRANCHES: "main"

  create_release:
    name: Create release
    runs-on: ubuntu-latest
    needs: [tag]
    steps:
      - name: Checkout code
        uses: actions/checkout@v4
      - name: Create Release
        uses: actions/create-release@v1
        env:
          GITHUB_TOKEN: ${{ secrets.ACTIONS_TOKEN }}
        with:
          tag_name: ${{ needs.tag.outputs.tag_name }}
          release_name: Release ${{ needs.tag.outputs.tag_name }}
          draft: false
          prerelease: false

  create_docker:
    name: Publish Docker Images
    runs-on: ubuntu-latest
    needs: create_release
    steps:
      - name: Update Docker configuration
        continue-on-error: true

**Decision: Reject** **Change Score: 2/10** This diff is a mess! It's full of commented-out code, commented-out jobs, and generally looks like someone was experimenting without cleaning up afterward. The changes lack a clear purpose and introduce unnecessary complexity. This is a step backward, not forward. Here's a breakdown of the issues and suggested fixes: 1. **Commenting out CI job:** Removing the CI job is a bad idea. CI is crucial for ensuring code quality and preventing regressions. Revert this change. 2. **Commenting out `get_release_id` and `publish_pypi` jobs**: Why are these jobs being disabled? Understand the reason and either fix the underlying issue or remove the jobs entirely if they are truly obsolete. Don't just comment them out. 3. **Inconsistent commenting styles:** Some sections are fully commented out, while others have individual lines commented out. Be consistent. Choose one approach and stick to it. 4. **General cleanup needed:** Remove all the commented-out code and jobs. It clutters the workflow and makes it harder to understand. If you're not using it, delete it. 5. **Missing Dependencies**: The create_docker job depends on create_release, not tag. I strongly suggest you revert these changes, clean up the workflow file, and then resubmit with a clear explanation of the intended changes and their benefits. Before even thinking of submitting this code, run the workflow locally to check if it works. ```yaml name: Release on: workflow_dispatch: schedule: - cron: '0 9 * * 0' jobs: tag: name: Tag release runs-on: ubuntu-latest outputs: tag_name: ${{ steps.tag_release.outputs.tag_name }} steps: - name: Checkout code uses: actions/checkout@v4 with: fetch-depth: 0 - name: Bump version and create tag id: tag_release uses: anothrNick/github-tag-action@1.66.0 env: GITHUB_TOKEN: ${{ secrets.ACTIONS_TOKEN }} DEFAULT_BUMP: patch WITH_V: true RELEASE_BRANCHES: "main" create_release: name: Create release runs-on: ubuntu-latest needs: [tag] steps: - name: Checkout code uses: actions/checkout@v4 - name: Create Release uses: actions/create-release@v1 env: GITHUB_TOKEN: ${{ secrets.ACTIONS_TOKEN }} with: tag_name: ${{ needs.tag.outputs.tag_name }} release_name: Release ${{ needs.tag.outputs.tag_name }} draft: false prerelease: false create_docker: name: Publish Docker Images runs-on: ubuntu-latest needs: create_release steps: - name: Update Docker configuration continue-on-error: true ```

luke merged commit 0202619cb8 into main

2025-05-10 21:59:23 +02:00

luke referenced this issue from a commit

2025-05-10 21:59:23 +02:00

fix(ci): fix release workflow (#351)

luke deleted branch release-flow

2025-05-10 21:59:25 +02:00

luke referenced this issue from a commit

2025-05-10 22:45:58 +02:00

Update git.tainton.uk/repos/roboluke Docker tag to v1.30.1 (#4)

Sign in to join this conversation.