mirrors/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2026-02-14 17:02:27 +00:00
Code Activity

fix: update localized name and description of ldap group name attribute (#892)

Browse Source
This commit is contained in:
Kyle Mendell
2025-08-27 15:52:50 -05:00
committed by GitHub
parent a4e965434f
commit e88be7e61a
3 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/messages/en.json
View File

@@ -215,7 +215,7 @@
"group_members_attribute": "Group Members Attribute", "group_members_attribute": "Group Members Attribute",
"the_attribute_to_use_for_querying_members_of_a_group": "The attribute to use for querying members of a group.", "the_attribute_to_use_for_querying_members_of_a_group": "The attribute to use for querying members of a group.",
"group_unique_identifier_attribute": "Group Unique Identifier Attribute", "group_unique_identifier_attribute": "Group Unique Identifier Attribute",
"group_name_attribute": "Group Name Attribute", "group_rdn_attribute": "Group RDN Attribute (in DN)",
"admin_group_name": "Admin Group Name", "admin_group_name": "Admin Group Name",
"members_of_this_group_will_have_admin_privileges_in_pocketid": "Members of this group will have Admin Privileges in Pocket ID.", "members_of_this_group_will_have_admin_privileges_in_pocketid": "Members of this group will have Admin Privileges in Pocket ID.",
"disable": "Disable", "disable": "Disable",
@@ -442,6 +442,6 @@
"invalid_client_id": "Client ID can only contain letters, numbers, underscores, and hyphens", "invalid_client_id": "Client ID can only contain letters, numbers, underscores, and hyphens",
"custom_client_id_description": "Set a custom client ID if this is required by your application. Otherwise, leave it blank to generate a random one.", "custom_client_id_description": "Set a custom client ID if this is required by your application. Otherwise, leave it blank to generate a random one.",
"generated": "Generated", "generated": "Generated",
"administration": "Administration" "administration": "Administration",
"group_rdn_attribute_description": "The attribute used in the groups distinguished name (DN). Recommended value: `cn`"
} }

3
frontend/src/routes/settings/admin/application-configuration/forms/app-config-ldap-form.svelte
View File

@@ -200,7 +200,8 @@
bind:input={$inputs.ldapAttributeGroupUniqueIdentifier} bind:input={$inputs.ldapAttributeGroupUniqueIdentifier}
/> />
<FormInput <FormInput
label={m.group_name_attribute()} label={m.group_rdn_attribute()}
description={m.group_rdn_attribute_description()}
placeholder="cn" placeholder="cn"
bind:input={$inputs.ldapAttributeGroupName} bind:input={$inputs.ldapAttributeGroupName}
/> />

2
tests/specs/ldap.spec.ts
View File

@@ -21,7 +21,7 @@ test.describe('LDAP Integration', () => {
await expect(page.getByLabel('User Unique Identifier Attribute')).not.toBeEmpty(); await expect(page.getByLabel('User Unique Identifier Attribute')).not.toBeEmpty();
await expect(page.getByLabel('Username Attribute')).not.toBeEmpty(); await expect(page.getByLabel('Username Attribute')).not.toBeEmpty();
await expect(page.getByLabel('User Mail Attribute')).not.toBeEmpty(); await expect(page.getByLabel('User Mail Attribute')).not.toBeEmpty();
await expect(page.getByLabel('Group Name Attribute')).not.toBeEmpty(); await expect(page.getByLabel('Group RDN Attribute (in DN)')).not.toBeEmpty();
const syncButton = page.getByRole('button', { name: 'Sync now' }); const syncButton = page.getByRole('button', { name: 'Sync now' });
await syncButton.click(); await syncButton.click();