From 7885ae011c7390ee9f71ddad2d6742b517c1af67 Mon Sep 17 00:00:00 2001
From: Elias Schneider <login@eliasschneider.com>
Date: Mon, 10 Mar 2025 14:05:51 +0100
Subject: [PATCH] tests: fix user group assignment test

---
 frontend/tests/user-settings.spec.ts | 53 +++++-----------------------
 1 file changed, 8 insertions(+), 45 deletions(-)

diff --git a/frontend/tests/user-settings.spec.ts b/frontend/tests/user-settings.spec.ts
index 9c421a5a..111beab5 100644
--- a/frontend/tests/user-settings.spec.ts
+++ b/frontend/tests/user-settings.spec.ts
@@ -1,5 +1,5 @@
 import test, { expect } from '@playwright/test';
-import { users, userGroups } from './data';
+import { userGroups, users } from './data';
 import { cleanupBackend } from './utils/cleanup.util';
 
 test.beforeEach(cleanupBackend);
@@ -183,58 +183,21 @@ test('Update user group assignments', async ({ page }) => {
 	const user = users.craig;
 	await page.goto(`/settings/admin/users/${user.id}`);
 
-	// Increase the test timeout since this test is complex
-	test.setTimeout(30000);
+	page.getByRole('button', { name: 'Expand card' }).first().click();
 
-	// Expand the user groups section if it's collapsed
-	const expandButton = page.getByRole('button', { name: 'Expand card' }).first();
-	if (await expandButton.isVisible()) {
-		await expandButton.click();
-	}
+	await page.getByRole('row', { name: userGroups.developers.name }).getByRole('checkbox').click();
+	await page.getByRole('row', { name: userGroups.designers.name }).getByRole('checkbox').click();
 
-	// Wait for the user groups table to load
-	await page.waitForSelector('table');
-
-	// First, ensure we start with a clean state - uncheck any checked boxes
-	const developersCheckbox = page
-		.getByRole('row', { name: userGroups.developers.name })
-		.getByRole('checkbox');
-	const designersCheckbox = page
-		.getByRole('row', { name: userGroups.designers.name })
-		.getByRole('checkbox');
-
-	// Force click if needed to overcome element interception issues
-	if ((await developersCheckbox.getAttribute('data-state')) === 'checked') {
-		await developersCheckbox.click({ force: true });
-	}
-
-	if ((await designersCheckbox.getAttribute('data-state')) === 'checked') {
-		await designersCheckbox.click({ force: true });
-	}
-
-	// Save the changes to reset state if needed
 	await page.getByRole('button', { name: 'Save' }).nth(1).click();
 
-	// Wait for toast message to appear and disappear
-	await expect(page.getByRole('status')).toHaveText('User groups updated successfully');
-	await page.waitForTimeout(1000); // Wait for any animations or state changes
-
-	// Now add both groups (using force: true to avoid interception problems)
-	await developersCheckbox.click({ force: true });
-	await designersCheckbox.click({ force: true });
-
-	// Save the changes
-	await page.getByRole('button', { name: 'Save' }).nth(1).click();
-
-	// Verify success message
 	await expect(page.getByRole('status')).toHaveText('User groups updated successfully');
 
 	await page.reload();
 
-	await expect(
-		page.getByRole('row', { name: userGroups.developers.name }).getByRole('checkbox')
-	).toHaveAttribute('data-state', 'checked', { timeout: 10000 });
 	await expect(
 		page.getByRole('row', { name: userGroups.designers.name }).getByRole('checkbox')
-	).toHaveAttribute('data-state', 'checked', { timeout: 10000 });
+	).toHaveAttribute('data-state', 'checked');
+	await expect(
+		page.getByRole('row', { name: userGroups.developers.name }).getByRole('checkbox')
+	).toHaveAttribute('data-state', 'unchecked');
 });