From 0e44f245afcdf8179bf619613ca9ef4bffa176ca Mon Sep 17 00:00:00 2001
From: Elias Schneider <login@eliasschneider.com>
Date: Tue, 12 Aug 2025 09:46:15 +0200
Subject: [PATCH] fix: non admin users can't revoke oidc client but see edit
 link

---
 .../apps/authorized-oidc-client-card.svelte        | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/frontend/src/routes/settings/apps/authorized-oidc-client-card.svelte b/frontend/src/routes/settings/apps/authorized-oidc-client-card.svelte
index 79e631fa..9627f80d 100644
--- a/frontend/src/routes/settings/apps/authorized-oidc-client-card.svelte
+++ b/frontend/src/routes/settings/apps/authorized-oidc-client-card.svelte
@@ -66,17 +66,17 @@
 							<span class="sr-only">{m.toggle_menu()}</span>
 						</DropdownMenu.Trigger>
 						<DropdownMenu.Content align="end">
-							<DropdownMenu.Item
-								onclick={() => goto(`/settings/admin/oidc-clients/${authorizedClient.client.id}`)}
-								><LucidePencil class="mr-2 size-4" /> {m.edit()}</DropdownMenu.Item
-							>
 							{#if $userStore?.isAdmin}
 								<DropdownMenu.Item
-									class="text-red-500 focus:!text-red-700"
-									onclick={() => onRevoke(authorizedClient.client)}
-									><LucideBan class="mr-2 size-4" />{m.revoke()}</DropdownMenu.Item
+									onclick={() => goto(`/settings/admin/oidc-clients/${authorizedClient.client.id}`)}
+									><LucidePencil class="mr-2 size-4" /> {m.edit()}</DropdownMenu.Item
 								>
 							{/if}
+							<DropdownMenu.Item
+								class="text-red-500 focus:!text-red-700"
+								onclick={() => onRevoke(authorizedClient.client)}
+								><LucideBan class="mr-2 size-4" />{m.revoke()}</DropdownMenu.Item
+							>
 						</DropdownMenu.Content>
 					</DropdownMenu.Root>
 				</div>