diff --git a/.golangci.yml b/.golangci.yml index db25b05..35f8c7f 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -22,6 +22,12 @@ linters: - wsl # We use wsl_v5 instead - wrapcheck # Adds too much bloat, many of the errors are contextual enough and don't need wrapping + settings: + goconst: + ignore-string-values: + - "get" + - "list" + exclusions: # Typical presets to exclude: https://golangci-lint.run/docs/linters/false-positives/#exclusion-presets presets: @@ -36,6 +42,7 @@ linters: - dupl # We don't mind duplicated code in tests. It helps with clarity - varnamelen # We don't mind short var names in tests. - revive # Complains too much about unused-params, but they help with tests readibility + - funlen # We don't mind long functions in tests - path: test/ linters: - dupl diff --git a/pkg/url_test.go b/pkg/url_test.go index 934c211..8bccd87 100644 --- a/pkg/url_test.go +++ b/pkg/url_test.go @@ -131,11 +131,11 @@ func TestDefaultScheme(t *testing.T) { func TestInvalidURLParse(t *testing.T) { invalidURLs := []string{ "", - //TODO: This Path is technically a correct scp-like syntax. Not sure how to handle it + // TODO: This Path is technically a correct scp-like syntax. Not sure how to handle it "github.com:grdl/git-git.get.git", - //TODO: Is this a valid git Path? - //"git@github.com:1234:grdl/git-get.git", + // TODO: Is this a valid git Path? + // "git@github.com:1234:grdl/git-get.git", } for _, test := range invalidURLs {