6
0
mirror of https://github.com/grdl/git-get.git synced 2026-02-13 00:00:16 +00:00

Fix issues found by revive linter

This commit is contained in:
Grzegorz Dlugoszewski
2025-08-24 16:09:27 +02:00
parent 5f60e973f6
commit 599643892b
8 changed files with 11 additions and 7 deletions

View File

@@ -26,6 +26,7 @@ linters:
linters: linters:
- dupl # We don't mind duplicated code in tests. It helps with clarity - dupl # We don't mind duplicated code in tests. It helps with clarity
- varnamelen # We don't mind short var names in tests. - varnamelen # We don't mind short var names in tests.
- revive # Complains too much about unused-params, but they help with tests readibility
- path: test/ - path: test/
linters: linters:
- dupl - dupl

View File

@@ -45,7 +45,7 @@ func newGetCommand() *cobra.Command {
return cmd return cmd
} }
func runGetCommand(cmd *cobra.Command, args []string) error { func runGetCommand(_ *cobra.Command, args []string) error {
var url string var url string
if len(args) > 0 { if len(args) > 0 {
url = args[0] url = args[0]

View File

@@ -35,7 +35,7 @@ func newListCommand() *cobra.Command {
return cmd return cmd
} }
func runListCommand(cmd *cobra.Command, args []string) error { func runListCommand(_ *cobra.Command, _ []string) error {
cfg.Expand(cfg.KeyReposRoot) cfg.Expand(cfg.KeyReposRoot)
config := &pkg.ListCfg{ config := &pkg.ListCfg{

View File

@@ -1,3 +1,7 @@
// This program behaves as a git subcommand (see https://git.github.io/htmldocs/howto/new-command.html)
// When added to PATH, git recognizes it as its subcommand and it can be invoked as "git get..." or "git list..."
// It can also be invoked as a regular binary with subcommands: "git-get get..." or "git-get list"
// The following flow detects the invokation method and runs the appropriate command.
package main package main
import ( import (
@@ -6,11 +10,6 @@ import (
"strings" "strings"
) )
// This program behaves as a git subcommand (see https://git.github.io/htmldocs/howto/new-command.html)
// When added to PATH, git recognizes it as its subcommand and it can be invoked as "git get..." or "git list..."
// It can also be invoked as a regular binary with subcommands: "git-get get..." or "git-get list"
// The following flow detects the invokation method and runs the appropriate command.
func main() { func main() {
command, args := determineCommand() command, args := determineCommand()
executeCommand(command, args) executeCommand(command, args)

View File

@@ -1,3 +1,4 @@
// Package git implements functionalities to read and manipulate git repositories
package git package git
import ( import (

View File

@@ -1,3 +1,4 @@
// Package test contains helper utilities and functions creating pre-configured test repositories for testing purposes
package test package test
import ( import (

View File

@@ -1,3 +1,4 @@
// Package print implements different outputs for git-list command
package print package print
import ( import (

View File

@@ -1,3 +1,4 @@
// Package pkg implements the primary funcionality of the commands: list and get
package pkg package pkg
import ( import (