mirrors/git-get
6
0
Fork 0
mirror of https://github.com/grdl/git-get.git synced 2026-02-07 17:34:18 +00:00
Code Activity

Fix issues found by goerrcheck linter

Browse Source
This commit is contained in:
Grzegorz Dlugoszewski
2025-08-24 16:33:15 +02:00
parent 599643892b
commit 1e1584ba33
6 changed files with 35 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/cfg/config.go
View File

@@ -92,7 +92,11 @@ func readGitconfig(cfg Gitconfig) {
}
viper.SetConfigType("env")
viper.ReadConfig(bytes.NewBuffer([]byte(strings.Join(lines, "\n"))))
if err := viper.ReadConfig(bytes.NewBuffer([]byte(strings.Join(lines, "\n")))); err != nil {
// Log error but don't fail - configuration is optional
fmt.Fprintf(os.Stderr, "Warning: failed to read git config: %v\n", err)
}
// TODO: A hacky way to read boolean flag from gitconfig. Find a cleaner way.
if val := cfg.Get(fmt.Sprintf("%s.%s", GitgetPrefix, KeySkipHost)); strings.ToLower(val) == "true" {

16
pkg/cfg/config_test.go
View File

@@ -95,22 +95,28 @@ func testConfigOnlyInGitconfig(t *testing.T) {
func testConfigOnlyInEnvVar(t *testing.T) {
Init(&gitconfigEmpty{})
os.Setenv(envVarName, fromEnv)
t.Setenv(envVarName, fromEnv)
}
func testConfigInGitconfigAndEnvVar(t *testing.T) {
Init(&gitconfigValid{})
os.Setenv(envVarName, fromEnv)
t.Setenv(envVarName, fromEnv)
}
func testConfigInFlag(t *testing.T) {
Init(&gitconfigValid{})
os.Setenv(envVarName, fromEnv)
t.Setenv(envVarName, fromEnv)
cmd := cobra.Command{}
cmd.PersistentFlags().String(KeyDefaultHost, Defaults[KeyDefaultHost], "")
viper.BindPFlag(KeyDefaultHost, cmd.PersistentFlags().Lookup(KeyDefaultHost))
if err := viper.BindPFlag(KeyDefaultHost, cmd.PersistentFlags().Lookup(KeyDefaultHost)); err != nil {
t.Fatalf("failed to bind flag: %v", err)
}
cmd.SetArgs([]string{"--" + KeyDefaultHost, fromFlag})
cmd.Execute()
if err := cmd.Execute(); err != nil {
t.Fatalf("failed to execute command: %v", err)
}
}