linting

tests-ng/helpers

@@ -1,3 +1,4 @@
+# shellcheck disable=SC2148
 # author: deadc0de6 (https://github.com/deadc0de6)
 # Copyright (c) 2017, deadc0de6
 #
@@ -14,6 +15,7 @@ declare -a to_be_cleared
 clear_on_exit()
 {
   local len="${#to_be_cleared[*]}"
+  # shellcheck disable=SC2004
   to_be_cleared[${len}]="$1"
   if [ "${len}" = "0" ]; then
     # set trap
@@ -37,14 +39,16 @@ on_exit()
 create_dir()
 {
   dirs="a/aa a/ab a/ac b/ba c"
-  mkdir -p ${1}
+  mkdir -p "${1}"
   for d in ${dirs}; do
     # create some dirs
-    mkdir -p ${1}/${d}
+    mkdir -p "${1}"/"${d}"
     # create some files
-    fn=`echo ${d} | sed 's#/#-#g'`
+    # shellcheck disable=SC2001
+    fn=$(echo "${d}" | sed 's#/#-#g')
     f="${1}/${d}/${fn}"
-    echo "${d}" > ${f}
+    echo "${d}" > "${f}"
+    # shellcheck disable=SC2034
     token=${f}
   done
 }
@@ -54,7 +58,7 @@ create_dir()
 # $1: path to save to
 create_conf()
 {
-  cat > ${1} << _EOF
+  cat > "${1}" << _EOF
 config:
   backup: true
   create: true