Merge pull request #8 from SShrike/master

Make dotdrop.sh pass all of the ShellCheck lints

dotdrop.sh

@@ -1,29 +1,31 @@
-#!/bin/sh
+#!/usr/bin/env bash
 # author: deadc0de6 (https://github.com/deadc0de6)
 # Copyright (c) 2017, deadc0de6
 
 # check for readlink/realpath presence
 # https://github.com/deadc0de6/dotdrop/issues/6
 rl="readlink -f"
-${rl} ${0} >/dev/null 2>&1
+
-if [ "$?" != "0" ]; then
+if ! ${rl} "${0}" >/dev/null 2>&1; then
   rl="realpath"
-  hash ${rl}
+
-  [ "$?" != "0" ] && echo "\"${rl}\" not found !" && exit 1
+  if ! hash ${rl}; then
+    echo "\"${rl}\" not found !" && exit 1
+  fi
 fi
 
 # setup variables
-args="$@"
+args=("$@")
-cur=`dirname $(${rl} ${0})`
+cur=$(dirname "$(${rl} "${0}")")
-opwd=`pwd`
+opwd=$(pwd)
 bin="${cur}/dotdrop/dotdrop.py"
 cfg="${cur}/config.yaml"
 
 # pivot
-cd ${cur}
+cd "${cur}" || { echo "Folder \"${cur}\" doesn't exist, aborting." && exit; }
 # init the submodule
 git submodule update --init --recursive
 # launch dotdrop
-python3 ${bin} --cfg=${cfg} $args
+python3 "${bin}" --cfg="${cfg}" "${args[@]}"
 # pivot back
-cd ${opwd}
+cd "${opwd}" || { echo "Folder \"${opwd}\" doesn't exist, aborting." && exit; }