From 723cdaef5ed9135539acdb1961255032e4656add Mon Sep 17 00:00:00 2001 From: deadc0de6 Date: Sun, 5 Feb 2023 18:11:51 +0100 Subject: [PATCH] linting --- tests/test_options.py | 102 ++++++++++++++++++++++-------------------- 1 file changed, 53 insertions(+), 49 deletions(-) diff --git a/tests/test_options.py b/tests/test_options.py index 0102192..84aec04 100644 --- a/tests/test_options.py +++ b/tests/test_options.py @@ -23,38 +23,42 @@ class FakeOptions(Options): self.log = Logger(debug=True) +def clean_setup(): + """clean stuff""" + if 'DOTDROP_CONFIG' in os.environ: + del os.environ['DOTDROP_CONFIG'] + if 'XDG_CONFIG_HOME' in os.environ: + del os.environ['XDG_CONFIG_HOME'] + + +def get_args(more): + """return args dict""" + args = { + '--dry': False, + '--verbose': True, + '--cfg': '', + } + for k, val in more.items(): + args[k] = val + return args + + +def side_effect(valid=''): + """side effect for os.path.exists""" + def inner(filename): + print(f'checking if {filename} exists') + if filename == valid: + return True + return False + return inner + + class TestOptions(unittest.TestCase): """test case""" - def clean_setup(self): - """clean stuff""" - if 'DOTDROP_CONFIG' in os.environ: - del os.environ['DOTDROP_CONFIG'] - if 'XDG_CONFIG_HOME' in os.environ: - del os.environ['XDG_CONFIG_HOME'] - - def _get_args(self, more): - args = { - '--dry': False, - '--verbose': True, - '--cfg': '', - } - for k, val in more.items(): - args[k] = val - return args - - def side_effect(self, valid=''): - """side effect for os.path.exists""" - def inner(filename): - print(f'checking if {filename} exists') - if filename == valid: - return True - return False - return inner - def test_get_path_from_cli(self): """from --cli""" - self.clean_setup() + clean_setup() expected = 'fakepath' args = {} args['--cfg'] = expected @@ -63,43 +67,43 @@ class TestOptions(unittest.TestCase): def test_get_path_from_env(self): """from env""" - self.clean_setup() + clean_setup() expected = 'envpath' os.environ['DOTDROP_CONFIG'] = expected - args = self._get_args({'--cfg': ''}) + args = get_args({'--cfg': ''}) fake = FakeOptions(args) self.assertEqual(fake._get_config_path(), expected) @patch('os.path.exists') def test_get_path_from_yaml(self, mock_exists): """from yaml""" - self.clean_setup() + clean_setup() mock_exists.return_value = True expected = 'config.yaml' - args = self._get_args({'--cfg': ''}) + args = get_args({'--cfg': ''}) fake = FakeOptions(args) self.assertEqual(fake._get_config_path(), expected) @patch('os.path.exists') def test_get_path_from_toml(self, mock_exists): """from toml""" - self.clean_setup() + clean_setup() expected = 'config.toml' - args = self._get_args({'--cfg': ''}) - mock_exists.side_effect = self.side_effect(valid=expected) + args = get_args({'--cfg': ''}) + mock_exists.side_effect = side_effect(valid=expected) fake = FakeOptions(args) self.assertEqual(fake._get_config_path(), expected) @patch('os.path.exists') def test_get_path_xdg_yaml(self, mock_exists): """from xdg""" - self.clean_setup() + clean_setup() home = os.path.expanduser('~/.config') expected = f'{home}/dotdrop/config.yaml' - mock_exists.side_effect = self.side_effect(valid=expected) + mock_exists.side_effect = side_effect(valid=expected) log = Logger(debug=True) log.dbg(f'expected: {expected}') - args = self._get_args({'--cfg': ''}) + args = get_args({'--cfg': ''}) os.environ['XDG_CONFIG_HOME'] = home fake = FakeOptions(args) self.assertEqual(fake._get_config_path(), expected) @@ -107,13 +111,13 @@ class TestOptions(unittest.TestCase): @patch('os.path.exists') def test_get_path_xdg_toml(self, mock_exists): """from xdg toml""" - self.clean_setup() + clean_setup() home = os.path.expanduser('~/.config') expected = f'{home}/dotdrop/config.toml' - mock_exists.side_effect = self.side_effect(valid=expected) + mock_exists.side_effect = side_effect(valid=expected) log = Logger(debug=True) log.dbg(f'expected: {expected}') - args = self._get_args({'--cfg': ''}) + args = get_args({'--cfg': ''}) os.environ['XDG_CONFIG_HOME'] = home fake = FakeOptions(args) self.assertEqual(fake._get_config_path(), expected) @@ -121,39 +125,39 @@ class TestOptions(unittest.TestCase): @patch('os.path.exists') def test_get_path_fs_yaml(self, mock_exists): """from fs yaml""" - self.clean_setup() + clean_setup() home = os.path.expanduser('~/.config') expected = f'{home}/dotdrop/config.toml' - mock_exists.side_effect = self.side_effect(valid=expected) + mock_exists.side_effect = side_effect(valid=expected) log = Logger(debug=True) log.dbg(f'expected: {expected}') - args = self._get_args({'--cfg': ''}) + args = get_args({'--cfg': ''}) fake = FakeOptions(args) self.assertEqual(fake._get_config_path(), expected) @patch('os.path.exists') def test_get_path_fs_xdg(self, mock_exists): """from fs xdg""" - self.clean_setup() + clean_setup() home = os.path.expanduser('/etc/xdg') expected = f'{home}/dotdrop/config.toml' - mock_exists.side_effect = self.side_effect(valid=expected) + mock_exists.side_effect = side_effect(valid=expected) log = Logger(debug=True) log.dbg(f'expected: {expected}') - args = self._get_args({'--cfg': ''}) + args = get_args({'--cfg': ''}) fake = FakeOptions(args) self.assertEqual(fake._get_config_path(), expected) @patch('os.path.exists') def test_get_path_fs_etc(self, mock_exists): """from fs etc""" - self.clean_setup() + clean_setup() home = os.path.expanduser('/etc') expected = f'{home}/dotdrop/config.toml' - mock_exists.side_effect = self.side_effect(valid=expected) + mock_exists.side_effect = side_effect(valid=expected) log = Logger(debug=True) log.dbg(f'expected: {expected}') - args = self._get_args({'--cfg': ''}) + args = get_args({'--cfg': ''}) fake = FakeOptions(args) self.assertEqual(fake._get_config_path(), expected)