mirror of
https://github.com/tw93/Mole.git
synced 2026-03-22 21:20:09 +00:00
Fix --dry-run hiding system cleanup preview (#493)
The dry-run mode hardcoded SYSTEM_CLEAN=false, which meant the entire system section was silently skipped during preview. Users had no way to see what /Library/Caches, /private/var/log, diagnostics, or other sudo-required paths would be cleaned. Now dry-run checks for a cached sudo session (sudo -n) and includes the system preview when available. When sudo isn't cached, a hint tells the user how to get the full preview without running the whole script as root.
This commit is contained in:
12
bin/clean.sh
12
bin/clean.sh
@@ -717,7 +717,6 @@ start_cleanup() {
|
||||
if [[ "$DRY_RUN" == "true" ]]; then
|
||||
echo -e "${YELLOW}Dry Run Mode${NC}, Preview only, no deletions"
|
||||
echo ""
|
||||
SYSTEM_CLEAN=false
|
||||
|
||||
ensure_user_file "$EXPORT_LIST_FILE"
|
||||
cat > "$EXPORT_LIST_FILE" << EOF
|
||||
@@ -732,6 +731,17 @@ start_cleanup() {
|
||||
#
|
||||
|
||||
EOF
|
||||
|
||||
# Preview system section when sudo is already cached (no password prompt).
|
||||
if sudo -n true 2> /dev/null; then
|
||||
SYSTEM_CLEAN=true
|
||||
echo -e "${GREEN}${ICON_SUCCESS}${NC} Admin access available, system preview included"
|
||||
echo ""
|
||||
else
|
||||
SYSTEM_CLEAN=false
|
||||
echo -e "${GRAY}${ICON_WARNING} System caches need sudo, run ${NC}sudo -v && mo clean --dry-run${GRAY} for full preview${NC}"
|
||||
echo ""
|
||||
fi
|
||||
return
|
||||
fi
|
||||
|
||||
|
||||
Reference in New Issue
Block a user