mirrors/Mole
1
0
Fork 0
mirror of https://github.com/tw93/Mole.git synced 2026-03-22 20:50:06 +00:00
Code Activity

fix macOS update false positives

Browse Source
This commit is contained in:
root
2026-03-18 03:15:39 +01:00
parent 25892594b0
commit e6ee9ec490
2 changed files with 65 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
lib/check/all.sh
View File

@@ -386,9 +386,34 @@ check_macos_update() {
# Prefer avoiding false negatives: if the system indicates updates are pending,
# only clear the flag when softwareupdate returns a list without any update entries.
# However, macOS doesn't distinguish between system and App Store updates in the
# LastRecommendedUpdatesAvailable counter, so we additionally require that at least
# one listed update is a macOS system update before showing a macOS update warning.
if [[ $sw_status -eq 0 && -n "$sw_output" ]]; then
if ! echo "$sw_output" | grep -qE '^[[:space:]]*\*'; then
# No update entries at all
updates_available="false"
else
# softwareupdate output may include both macOS and App Store updates.
# Treat only entries whose Label contains "macOS" as system updates.
local has_macos_update="false"
while IFS= read -r line; do
[[ "$line" =~ ^[[:space:]]*\* ]] || continue
local label="$line"
label="${label#*Label: }"
label="${label%%,*}"
local lower_label
lower_label=$(printf '%s' "$label" | tr '[:upper:]' '[:lower:]')
if [[ "$lower_label" == macos* || "$lower_label" == *"macos "* || "$lower_label" == *" macos"* ]]; then
has_macos_update="true"
break
fi
done <<< "$sw_output"
if [[ "$has_macos_update" != "true" ]]; then
# Only App Store updates are pending – don't flag macOS as outdated
updates_available="false"
fi
fi
fi
fi