mirrors/Mole
1
0
Fork 0
mirror of https://github.com/tw93/Mole.git synced 2026-03-22 20:15:07 +00:00
Code Activity

Fix: Removed duplicate calls to clean_xcode_tools and clean_code_editors (#593)

Browse Source 
* removed duplicate calls to clean_xcode_tools and clean_code_editors

in lib/clean/app_caches.sh clean_user_gui_application() was making calls
to clean_xcode_tools and clean_code_editors.

in lib/clean/dev.sh clean_xcode_tools and clean_code_editors was also
being called, causing the duplication when executing the clean command.

removed the calls from lib/clean/app_caches.sh
clean_user_gui_application since these two calls are developer focused.

* test: cover removed developer app calls

---------

Co-authored-by: Tw93 <hitw93@gmail.com>
This commit is contained in:
Jason Costello
2026-03-18 11:25:49 -05:00
committed by GitHub
parent 06d2a3d029
commit e617ed2e76
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/clean/app_caches.sh
View File

@@ -240,8 +240,6 @@ clean_remote_desktop() {
# Main entry for GUI app cleanup. # Main entry for GUI app cleanup.
clean_user_gui_applications() { clean_user_gui_applications() {
stop_section_spinner stop_section_spinner
clean_xcode_tools
clean_code_editors
clean_communication_apps clean_communication_apps
clean_dingtalk clean_dingtalk
clean_ai_apps clean_ai_apps

8
tests/clean_app_caches.bats
View File

@@ -84,13 +84,17 @@ safe_clean() { :; }
clean_xcode_tools() { echo "xcode"; } clean_xcode_tools() { echo "xcode"; }
clean_code_editors() { echo "editors"; } clean_code_editors() { echo "editors"; }
clean_communication_apps() { echo "comm"; } clean_communication_apps() { echo "comm"; }
clean_dingtalk() { echo "dingtalk"; }
clean_ai_apps() { echo "ai"; }
clean_user_gui_applications clean_user_gui_applications
EOF EOF
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[[ "$output" == *"xcode"* ]] [[ "$output" != *"xcode"* ]]
[[ "$output" == *"editors"* ]] [[ "$output" != *"editors"* ]]
[[ "$output" == *"comm"* ]] [[ "$output" == *"comm"* ]]
[[ "$output" == *"dingtalk"* ]]
[[ "$output" == *"ai"* ]]
} }
@test "clean_ai_apps calls expected caches" { @test "clean_ai_apps calls expected caches" {