mirrors/Mole
1
0
Fork 0
mirror of https://github.com/tw93/Mole.git synced 2026-03-22 17:55:08 +00:00
Code Activity

fix(clean): avoid container cache scan stalls

Browse Source 
Add a lightweight top-level entry cap to Containers and Group
Containers scanning.  When a cache directory exceeds the threshold,
skip the expensive per-item du/find size scan and take a partial-size
/ "cleaned" output path instead.  Replace find-piped-to-read loops
with pure-bash glob iteration to cut external process overhead.

Closes #586
This commit is contained in:
Tw93
2026-03-18 14:49:12 +08:00
parent f88b2116ab
commit b8f3a0ecd3
2 changed files with 180 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
tests/clean_user_core.bats
View File

@@ -193,6 +193,39 @@ EOF
[[ "$output" != *"App caches"* ]] || [[ "$output" == *"already clean"* ]]
}
@test "clean_app_caches skips expensive size scans for large sandboxed caches" {
run env HOME="$HOME" PROJECT_ROOT="$PROJECT_ROOT" DRY_RUN=true /bin/bash --noprofile --norc <<'EOF'
set -euo pipefail
source "$PROJECT_ROOT/lib/core/common.sh"
source "$PROJECT_ROOT/lib/clean/user.sh"
start_section_spinner() { :; }
stop_section_spinner() { :; }
bytes_to_human() { echo "0B"; }
note_activity() { :; }
safe_clean() { :; }
should_protect_data() { return 1; }
is_critical_system_component() { return 1; }
get_path_size_kb() {
echo "SHOULD_NOT_SIZE_SCAN"
return 0
}
files_cleaned=0
total_size_cleaned=0
total_items=0
mkdir -p "$HOME/Library/Containers/com.example.large/Data/Library/Caches"
for i in $(seq 1 101); do
touch "$HOME/Library/Containers/com.example.large/Data/Library/Caches/file-$i.tmp"
done
clean_app_caches
EOF
[ "$status" -eq 0 ]
[[ "$output" == *"Sandboxed app caches"* ]]
[[ "$output" != *"SHOULD_NOT_SIZE_SCAN"* ]]
}
@test "clean_application_support_logs counts nested directory contents in dry-run size summary" {
run env HOME="$HOME" PROJECT_ROOT="$PROJECT_ROOT" DRY_RUN=true bash --noprofile --norc <<'EOF'
set -euo pipefail
@@ -451,6 +484,36 @@ EOF
[[ "$output" != *"Group Containers logs/caches"* ]]
}
@test "clean_group_container_caches skips per-item size scans for large candidates" {
run env HOME="$HOME" PROJECT_ROOT="$PROJECT_ROOT" DRY_RUN=true /bin/bash --noprofile --norc <<'EOF'
set -euo pipefail
source "$PROJECT_ROOT/lib/core/common.sh"
source "$PROJECT_ROOT/lib/clean/user.sh"
start_section_spinner() { :; }
stop_section_spinner() { :; }
bytes_to_human() { echo "0B"; }
note_activity() { :; }
get_path_size_kb() {
echo "SHOULD_NOT_SIZE_SCAN"
return 0
}
files_cleaned=0
total_size_cleaned=0
total_items=0
mkdir -p "$HOME/Library/Group Containers/group.com.example.large/Library/Caches"
for i in $(seq 1 101); do
touch "$HOME/Library/Group Containers/group.com.example.large/Library/Caches/file-$i.tmp"
done
clean_group_container_caches
EOF
[ "$status" -eq 0 ]
[[ "$output" == *"Group Containers logs/caches"* ]]
[[ "$output" != *"SHOULD_NOT_SIZE_SCAN"* ]]
}
@test "clean_finder_metadata respects protection flag" {
run env HOME="$HOME" PROJECT_ROOT="$PROJECT_ROOT" PROTECT_FINDER_METADATA=true /bin/bash --noprofile --norc <<'EOF'
set -euo pipefail