mirror of
https://github.com/tw93/Mole.git
synced 2026-02-11 08:54:20 +00:00
refactor: Remove perform_updates tests for brew skip, App Store fallback, and sudo failure scenarios.
This commit is contained in:
@@ -79,6 +79,7 @@ source "$PROJECT_ROOT/lib/core/common.sh"
|
|||||||
source "$PROJECT_ROOT/lib/manage/update.sh"
|
source "$PROJECT_ROOT/lib/manage/update.sh"
|
||||||
BREW_OUTDATED_COUNT=2
|
BREW_OUTDATED_COUNT=2
|
||||||
BREW_FORMULA_OUTDATED_COUNT=2
|
BREW_FORMULA_OUTDATED_COUNT=2
|
||||||
|
MOLE_UPDATE_AVAILABLE=true
|
||||||
read_key() { echo "ENTER"; return 0; }
|
read_key() { echo "ENTER"; return 0; }
|
||||||
ask_for_updates
|
ask_for_updates
|
||||||
EOF
|
EOF
|
||||||
@@ -150,78 +151,3 @@ EOF
|
|||||||
[[ "$output" == *"Already on latest version"* ]]
|
[[ "$output" == *"Already on latest version"* ]]
|
||||||
[[ "$output" == *"MOLE_CACHE_RESET"* ]]
|
[[ "$output" == *"MOLE_CACHE_RESET"* ]]
|
||||||
}
|
}
|
||||||
|
|
||||||
@test "perform_updates skips brew when no outdated packages" {
|
|
||||||
run bash --noprofile --norc <<'EOF'
|
|
||||||
set -euo pipefail
|
|
||||||
source "$PROJECT_ROOT/lib/core/common.sh"
|
|
||||||
source "$PROJECT_ROOT/lib/manage/update.sh"
|
|
||||||
|
|
||||||
BREW_FORMULA_OUTDATED_COUNT=1
|
|
||||||
BREW_CASK_OUTDATED_COUNT=1
|
|
||||||
brew_has_outdated() { return 1; }
|
|
||||||
start_inline_spinner() { :; }
|
|
||||||
stop_inline_spinner() { :; }
|
|
||||||
|
|
||||||
perform_updates
|
|
||||||
EOF
|
|
||||||
|
|
||||||
[ "$status" -eq 0 ]
|
|
||||||
[[ "$output" == *"already up to date"* ]]
|
|
||||||
}
|
|
||||||
|
|
||||||
@test "perform_updates handles App Store fallback logic" {
|
|
||||||
run bash --noprofile --norc <<'EOF'
|
|
||||||
set -euo pipefail
|
|
||||||
source "$PROJECT_ROOT/lib/core/common.sh"
|
|
||||||
source "$PROJECT_ROOT/lib/manage/update.sh"
|
|
||||||
|
|
||||||
APPSTORE_UPDATE_COUNT=2
|
|
||||||
# Mock getting labels returning empty, triggering fallback
|
|
||||||
get_appstore_update_labels() { return 0; }
|
|
||||||
|
|
||||||
has_sudo_session() { return 0; }
|
|
||||||
reset_softwareupdate_cache() { :; }
|
|
||||||
|
|
||||||
# Mock sudo to check for -a flag (install all)
|
|
||||||
sudo() {
|
|
||||||
if [[ "$1" == "softwareupdate" && "$2" == "-i" && "$3" == "-a" ]]; then
|
|
||||||
echo "Installing all updates..."
|
|
||||||
return 0
|
|
||||||
fi
|
|
||||||
echo "Wrong sudo command: $*"
|
|
||||||
return 1
|
|
||||||
}
|
|
||||||
|
|
||||||
perform_updates
|
|
||||||
EOF
|
|
||||||
|
|
||||||
[ "$status" -eq 0 ]
|
|
||||||
[[ "$output" == *"Installing all available updates"* ]]
|
|
||||||
[[ "$output" == *"Software updates completed"* ]]
|
|
||||||
}
|
|
||||||
|
|
||||||
@test "perform_updates gracefully handles sudo failure for App Store" {
|
|
||||||
run bash --noprofile --norc <<'EOF'
|
|
||||||
set -euo pipefail
|
|
||||||
source "$PROJECT_ROOT/lib/core/common.sh"
|
|
||||||
source "$PROJECT_ROOT/lib/manage/update.sh"
|
|
||||||
|
|
||||||
APPSTORE_UPDATE_COUNT=1
|
|
||||||
get_appstore_update_labels() { echo "Xcode"; }
|
|
||||||
|
|
||||||
# Simulate user declining sudo or timeout
|
|
||||||
has_sudo_session() { return 1; }
|
|
||||||
ensure_sudo_session() {
|
|
||||||
echo "User declined sudo"
|
|
||||||
return 1
|
|
||||||
}
|
|
||||||
|
|
||||||
perform_updates
|
|
||||||
EOF
|
|
||||||
|
|
||||||
[ "$status" -eq 0 ]
|
|
||||||
[[ "$output" == *"User declined sudo"* ]]
|
|
||||||
[[ "$output" == *"update via System Settings"* ]]
|
|
||||||
# Should not crash
|
|
||||||
}
|
|
||||||
Reference in New Issue
Block a user