mirrors/Mole
1
0
Fork 0
mirror of https://github.com/tw93/Mole.git synced 2026-02-16 10:36:12 +00:00
Code Activity

fix: handle spaces in dock item removal

Browse Source 
- URL-encode paths when matching against Dock persistent-apps
- Fixes issue where apps with spaces in names (e.g. 'Clash Party') were not removed from Dock
This commit is contained in:
Tw93
2026-01-15 11:40:49 +08:00
parent c34d91b36f
commit 9e1d09cb93
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/core/common.sh
View File

@@ -182,6 +182,9 @@ remove_apps_from_dock() {
full_path=$(cd "$(dirname "$app_path")" 2> /dev/null && pwd || echo "") full_path=$(cd "$(dirname "$app_path")" 2> /dev/null && pwd || echo "")
[[ -n "$full_path" ]] && full_path="$full_path/$(basename "$app_path")" [[ -n "$full_path" ]] && full_path="$full_path/$(basename "$app_path")"
# URL-encode the path for matching against Dock URLs (spaces -> %20)
local encoded_path="${full_path// /%20}"
# Find the index of the app in persistent-apps # Find the index of the app in persistent-apps
local i=0 local i=0
while true; do while true; do
@@ -196,8 +199,8 @@ remove_apps_from_dock() {
continue continue
} }
# Match by full path only to avoid removing apps with the same label. # Match by URL-encoded path to handle spaces in app names
if [[ -n "$full_path" && "$url" == *"$full_path"* ]]; then if [[ -n "$encoded_path" && "$url" == *"$encoded_path"* ]]; then
if /usr/libexec/PlistBuddy -c "Delete :persistent-apps:$i" "$plist" 2> /dev/null; then if /usr/libexec/PlistBuddy -c "Delete :persistent-apps:$i" "$plist" 2> /dev/null; then
changed=true changed=true
# After deletion, current index i now points to the next item # After deletion, current index i now points to the next item