mirrors/Mole
1
0
Fork 0
mirror of https://github.com/tw93/Mole.git synced 2026-03-22 19:05:07 +00:00
Code Activity

fix(windows): skip unresolved system volume optimization

Browse Source 
Refs #604
This commit is contained in:
Tw93
2026-03-21 13:26:20 +08:00
parent 73dd3e3c43
commit 95616d45c7
2 changed files with 39 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
bin/optimize.ps1
View File

@@ -133,6 +133,21 @@ function Get-SystemDriveLetter {
return $match.Value.ToUpperInvariant()
}
function Test-SystemDriveOptimizable {
param(
[Parameter(Mandatory = $true)]
[string]$DriveLetter
)
$getVolume = Get-Command Get-Volume -ErrorAction SilentlyContinue
if (-not $getVolume) {
return $true
}
$volume = Get-Volume -DriveLetter $DriveLetter -ErrorAction SilentlyContinue | Select-Object -First 1
return ($null -ne $volume)
}
function Optimize-DiskDrive {
<#
.SYNOPSIS
@@ -155,15 +170,31 @@ function Optimize-DiskDrive {
return
}
if (-not (Get-Command Optimize-Volume -ErrorAction SilentlyContinue)) {
Write-Host " $esc[90mDisk optimization skipped: Optimize-Volume is not available on this system$esc[0m"
return
}
try {
$systemDriveLetter = Get-SystemDriveLetter
if (-not (Test-SystemDriveOptimizable -DriveLetter $systemDriveLetter)) {
Write-Host " $esc[90mDisk optimization skipped: Windows could not resolve drive ${systemDriveLetter} to an optimizable volume$esc[0m"
return
}
Write-Host " Running Windows default optimization on drive ${systemDriveLetter}:..."
$null = Optimize-Volume -DriveLetter $systemDriveLetter -ErrorAction Stop
Write-Host " $esc[32m$($script:Icons.Success)$esc[0m Drive optimization completed"
$script:OptimizationsApplied++
}
catch {
Write-Host " $esc[31m$($script:Icons.Error)$esc[0m Disk optimization failed: $_"
$message = $_.Exception.Message
if ($message -match 'MSFT_Volume' -or $message -match 'DriveLetter') {
Write-Host " $esc[90mDisk optimization skipped: Windows could not resolve drive ${systemDriveLetter} to an optimizable volume$esc[0m"
return
}
Write-Host " $esc[31m$($script:Icons.Error)$esc[0m Disk optimization failed: $message"
}
}

7
tests/Commands.Tests.ps1
View File

@@ -61,6 +61,13 @@ Describe "Optimize Command" {
$result = & powershell -ExecutionPolicy Bypass -File "$script:BinDir\optimize.ps1" -ShowHelp 2>&1
$result -join "`n" | Should -Match "DryRun|Disk|DNS"
}
It "Should guard disk optimization when the system drive cannot be resolved to a volume" {
$source = Get-Content "$script:BinDir\optimize.ps1" -Raw
$source | Should -Match "function Test-SystemDriveOptimizable"
$source | Should -Match "Get-Volume -DriveLetter"
$source | Should -Match "Disk optimization skipped:"
}
}
}