From 878dfa1bde9614f3f41a4430d272f4fbf3509c59 Mon Sep 17 00:00:00 2001 From: tw93 Date: Tue, 10 Feb 2026 16:33:10 +0800 Subject: [PATCH] refactor(analyze): remove unused volume mount helper --- cmd/analyze/analyze_test.go | 23 ----------------------- cmd/analyze/main.go | 28 ---------------------------- 2 files changed, 51 deletions(-) diff --git a/cmd/analyze/analyze_test.go b/cmd/analyze/analyze_test.go index 25f3636..f8a4b84 100644 --- a/cmd/analyze/analyze_test.go +++ b/cmd/analyze/analyze_test.go @@ -329,29 +329,6 @@ func TestIsCleanableDir(t *testing.T) { } } -func TestHasUsefulVolumeMounts(t *testing.T) { - root := t.TempDir() - if hasUsefulVolumeMounts(root) { - t.Fatalf("empty directory should not report useful mounts") - } - - hidden := filepath.Join(root, ".hidden") - if err := os.Mkdir(hidden, 0o755); err != nil { - t.Fatalf("create hidden dir: %v", err) - } - if hasUsefulVolumeMounts(root) { - t.Fatalf("hidden entries should not count as useful mounts") - } - - mount := filepath.Join(root, "ExternalDrive") - if err := os.Mkdir(mount, 0o755); err != nil { - t.Fatalf("create mount dir: %v", err) - } - if !hasUsefulVolumeMounts(root) { - t.Fatalf("expected useful mount when real directory exists") - } -} - func TestLoadCacheExpiresWhenDirectoryChanges(t *testing.T) { home := t.TempDir() t.Setenv("HOME", home) diff --git a/cmd/analyze/main.go b/cmd/analyze/main.go index 5b92437..c8889b8 100644 --- a/cmd/analyze/main.go +++ b/cmd/analyze/main.go @@ -5,13 +5,11 @@ package main import ( "context" "fmt" - "io/fs" "os" "os/exec" "path/filepath" "slices" "sort" - "strings" "sync/atomic" "time" @@ -236,32 +234,6 @@ func createOverviewEntries() []dirEntry { return entries } -func hasUsefulVolumeMounts(path string) bool { - entries, err := os.ReadDir(path) - if err != nil { - return false - } - - for _, entry := range entries { - name := entry.Name() - if strings.HasPrefix(name, ".") { - continue - } - - info, err := os.Lstat(filepath.Join(path, name)) - if err != nil { - continue - } - if info.Mode()&fs.ModeSymlink != 0 { - continue // Ignore the synthetic MacintoshHD link - } - if info.IsDir() { - return true - } - } - return false -} - func (m *model) hydrateOverviewEntries() { m.entries = createOverviewEntries() if m.overviewSizeCache == nil {