From 7d62fa5e656e0bae49915f9302eb2b73492cf77a Mon Sep 17 00:00:00 2001
From: tw93 <tw93@qq.com>
Date: Sat, 31 Jan 2026 20:19:38 +0800
Subject: [PATCH] fix: improve performance of cache cleanup using find -delete

---
 lib/clean/user.sh | 34 +++++++++++++++++++++-------------
 1 file changed, 21 insertions(+), 13 deletions(-)

diff --git a/lib/clean/user.sh b/lib/clean/user.sh
index 99b6f7b..7e605e2 100644
--- a/lib/clean/user.sh
+++ b/lib/clean/user.sh
@@ -457,15 +457,18 @@ process_container_cache() {
         found_any=true
         ((cleaned_count++))
         if [[ "$DRY_RUN" != "true" ]]; then
-            # Clean contents safely with local nullglob.
-            local _ng_state
-            _ng_state=$(shopt -p nullglob || true)
-            shopt -s nullglob
-            for item in "$cache_dir"/*; do
-                [[ -e "$item" ]] || continue
-                safe_remove "$item" true || true
-            done
-            eval "$_ng_state"
+            # For directories with many files, use find -delete for performance
+            if ! find "$cache_dir" -mindepth 1 -delete 2> /dev/null; then
+                # Fallback: try item-by-item if find fails
+                local _ng_state
+                _ng_state=$(shopt -p nullglob || true)
+                shopt -s nullglob
+                for item in "$cache_dir"/*; do
+                    [[ -e "$item" ]] || continue
+                    safe_remove "$item" true || true
+                done
+                eval "$_ng_state"
+            fi
         fi
     fi
 }
@@ -604,10 +607,15 @@ clean_application_support_logs() {
                     ((cleaned_count++))
                     found_any=true
                     if [[ "$DRY_RUN" != "true" ]]; then
-                        for item in "$candidate"/*; do
-                            [[ -e "$item" ]] || continue
-                            safe_remove "$item" true > /dev/null 2>&1 || true
-                        done
+                        # For directories with many files, use find -delete for performance
+                        # This avoids shell expansion and individual safe_remove calls
+                        if ! find "$candidate" -mindepth 1 -delete 2> /dev/null; then
+                            # Fallback: try item-by-item if find fails
+                            for item in "$candidate"/*; do
+                                [[ -e "$item" ]] || continue
+                                safe_remove "$item" true > /dev/null 2>&1 || true
+                            done
+                        fi
                     fi
                 fi
             fi