feat: overhaul quality checks and expand test suite for clean and optimize features

tests/dev_caches.bats

@@ -0,0 +1,106 @@
+#!/usr/bin/env bats
+
+setup_file() {
+    PROJECT_ROOT="$(cd "${BATS_TEST_DIRNAME}/.." && pwd)"
+    export PROJECT_ROOT
+
+    ORIGINAL_HOME="${HOME:-}"
+    export ORIGINAL_HOME
+
+    HOME="$(mktemp -d "${BATS_TEST_DIRNAME}/tmp-dev-caches.XXXXXX")"
+    export HOME
+
+    mkdir -p "$HOME"
+}
+
+teardown_file() {
+    rm -rf "$HOME"
+    if [[ -n "${ORIGINAL_HOME:-}" ]]; then
+        export HOME="$ORIGINAL_HOME"
+    fi
+}
+
+@test "clean_dev_npm cleans orphaned pnpm store" {
+    run env HOME="$HOME" PROJECT_ROOT="$PROJECT_ROOT" bash --noprofile --norc <<'EOF'
+set -euo pipefail
+source "$PROJECT_ROOT/lib/core/common.sh"
+source "$PROJECT_ROOT/lib/clean/dev.sh"
+start_section_spinner() { :; }
+stop_section_spinner() { :; }
+clean_tool_cache() { echo "$1"; }
+safe_clean() { echo "$2"; }
+note_activity() { :; }
+pnpm() {
+    if [[ "$1" == "store" && "$2" == "prune" ]]; then
+        return 0
+    fi
+    if [[ "$1" == "store" && "$2" == "path" ]]; then
+        echo "/tmp/pnpm-store"
+        return 0
+    fi
+    return 0
+}
+npm() { return 0; }
+export -f pnpm npm
+clean_dev_npm
+EOF
+
+    [ "$status" -eq 0 ]
+    [[ "$output" == *"Orphaned pnpm store"* ]]
+}
+
+@test "clean_dev_docker skips when daemon not running" {
+    run env HOME="$HOME" PROJECT_ROOT="$PROJECT_ROOT" MO_DEBUG=1 DRY_RUN=false bash --noprofile --norc <<'EOF'
+set -euo pipefail
+source "$PROJECT_ROOT/lib/core/common.sh"
+source "$PROJECT_ROOT/lib/clean/dev.sh"
+start_section_spinner() { :; }
+stop_section_spinner() { :; }
+run_with_timeout() { return 1; }
+clean_tool_cache() { echo "$1"; }
+safe_clean() { echo "$2"; }
+debug_log() { echo "$*"; }
+docker() { return 1; }
+export -f docker
+clean_dev_docker
+EOF
+
+    [ "$status" -eq 0 ]
+    [[ "$output" == *"Docker daemon not running"* ]]
+    [[ "$output" != *"Docker build cache"* ]]
+}
+
+@test "clean_developer_tools runs key stages" {
+    run env HOME="$HOME" PROJECT_ROOT="$PROJECT_ROOT" bash --noprofile --norc <<'EOF'
+set -euo pipefail
+source "$PROJECT_ROOT/lib/clean/dev.sh"
+stop_section_spinner() { :; }
+clean_sqlite_temp_files() { :; }
+clean_dev_npm() { echo "npm"; }
+clean_homebrew() { echo "brew"; }
+clean_project_caches() { :; }
+clean_dev_python() { :; }
+clean_dev_go() { :; }
+clean_dev_rust() { :; }
+clean_dev_docker() { :; }
+clean_dev_cloud() { :; }
+clean_dev_nix() { :; }
+clean_dev_shell() { :; }
+clean_dev_frontend() { :; }
+clean_dev_mobile() { :; }
+clean_dev_jvm() { :; }
+clean_dev_other_langs() { :; }
+clean_dev_cicd() { :; }
+clean_dev_database() { :; }
+clean_dev_api_tools() { :; }
+clean_dev_network() { :; }
+clean_dev_misc() { :; }
+safe_clean() { :; }
+debug_log() { :; }
+clean_developer_tools
+EOF
+
+    [ "$status" -eq 0 ]
+    [[ "$output" == *"npm"* ]]
+    [[ "$output" == *"brew"* ]]
+}