mirrors/Mole
1
0
Fork 0
mirror of https://github.com/tw93/Mole.git synced 2026-02-16 23:24:11 +00:00
Code Activity

fix silent exit on permission denied during App State Cleanup (#440)

Browse Source
This commit is contained in:
NeedmeFordev
2026-02-11 11:40:34 +09:00
committed by GitHub
parent 5065c9cacb
commit 42893381e3
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/optimize/tasks.sh
View File

@@ -164,7 +164,7 @@ opt_cache_refresh() {
if [[ "$size_kb" =~ ^[0-9]+$ ]]; then if [[ "$size_kb" =~ ^[0-9]+$ ]]; then
total_cache_size=$((total_cache_size + size_kb)) total_cache_size=$((total_cache_size + size_kb))
fi fi
safe_remove "$target_path" true > /dev/null 2>&1 safe_remove "$target_path" true > /dev/null 2>&1 || true
fi fi
fi fi
done done
@@ -195,7 +195,7 @@ opt_saved_state_cleanup() {
if should_protect_path "$state_path"; then if should_protect_path "$state_path"; then
continue continue
fi fi
safe_remove "$state_path" true > /dev/null 2>&1 safe_remove "$state_path" true > /dev/null 2>&1 || true
done < <(command find "$state_dir" -type d -name "*.savedState" -mtime "+$MOLE_SAVED_STATE_AGE_DAYS" -print0 2> /dev/null) done < <(command find "$state_dir" -type d -name "*.savedState" -mtime "+$MOLE_SAVED_STATE_AGE_DAYS" -print0 2> /dev/null)
fi fi

17
tests/clean_system_maintenance.bats
View File

@@ -500,6 +500,23 @@ EOF
[[ "$output" == *"App saved states optimized"* ]] [[ "$output" == *"App saved states optimized"* ]]
} }
@test "opt_saved_state_cleanup continues on permission denied (silent exit)" {
local state_dir="$HOME/Library/Saved Application State"
mkdir -p "$state_dir/com.example.old.savedState"
touch -t 202301010000 "$state_dir/com.example.old.savedState" 2>/dev/null || true
run env HOME="$HOME" PROJECT_ROOT="$PROJECT_ROOT" bash --noprofile --norc << 'EOF'
set -euo pipefail
source "$PROJECT_ROOT/lib/core/common.sh"
source "$PROJECT_ROOT/lib/optimize/tasks.sh"
safe_remove() { return 1; }
opt_saved_state_cleanup
EOF
[ "$status" -eq 0 ]
[[ "$output" == *"App saved states optimized"* ]]
}
@test "opt_cache_refresh cleans Quick Look cache" { @test "opt_cache_refresh cleans Quick Look cache" {
mkdir -p "$HOME/Library/Caches/com.apple.QuickLook.thumbnailcache" mkdir -p "$HOME/Library/Caches/com.apple.QuickLook.thumbnailcache"
touch "$HOME/Library/Caches/com.apple.QuickLook.thumbnailcache/test.db" touch "$HOME/Library/Caches/com.apple.QuickLook.thumbnailcache/test.db"