mirrors/Mole
1
0
Fork 0
mirror of https://github.com/tw93/Mole.git synced 2026-02-12 04:43:59 +00:00
Code Activity

fix: P1/P2 issues in file ops, menu state, and logging

Browse Source 
- Fix safe_sudo_remove early exit on error (P1)
- Fix menu filter state leakage in paginated menu (P2)
- Fix cleanup of MOLE_MENU_FILTER_NAMES in app selector (P2)
- Correct log_operation signature for memory dumps (P2)
- Apply minor formatting fixes to dev cleanup module
This commit is contained in:
tw93
2026-02-07 11:21:37 +08:00
parent 6f8f16ce48
commit 361d0dda05
5 changed files with 26 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/clean/system.sh
View File

@@ -179,7 +179,7 @@ clean_deep_system() {
if oplog_enabled && [[ "$total_size_kb" -gt 0 ]]; then if oplog_enabled && [[ "$total_size_kb" -gt 0 ]]; then
local size_human local size_human
size_human=$(bytes_to_human "$((total_size_kb * 1024))") size_human=$(bytes_to_human "$((total_size_kb * 1024))")
log_operation "[clean] REMOVED $mem_reports_dir ($file_count files, $size_human)" log_operation "clean" "REMOVED" "$mem_reports_dir" "$file_count files, $size_human"
fi fi
else else
log_info "[DRY-RUN] Would remove $file_count old memory exception reports ($total_size_kb KB)" log_info "[DRY-RUN] Would remove $file_count old memory exception reports ($total_size_kb KB)"

3
lib/core/file_ops.sh
View File

@@ -366,8 +366,7 @@ safe_sudo_remove() {
local output local output
local ret local ret
output=$(sudo rm -rf "$path" 2>&1) # safe_remove output=$(sudo rm -rf "$path" 2>&1) || ret=$? # safe_remove
ret=$?
if [[ $ret -eq 0 ]]; then if [[ $ret -eq 0 ]]; then
log_operation "${MOLE_CURRENT_COMMAND:-clean}" "REMOVED" "$path" "$size_human" log_operation "${MOLE_CURRENT_COMMAND:-clean}" "REMOVED" "$path" "$size_human"

2
lib/ui/app_selector.sh
View File

@@ -169,7 +169,7 @@ select_apps_for_uninstall() {
local exit_code=$? local exit_code=$?
# Clean env leakage for safety # Clean env leakage for safety
unset MOLE_MENU_META_EPOCHS MOLE_MENU_META_SIZEKB unset MOLE_MENU_META_EPOCHS MOLE_MENU_META_SIZEKB MOLE_MENU_FILTER_NAMES
# leave MOLE_MENU_SORT_DEFAULT untouched if user set it globally # leave MOLE_MENU_SORT_DEFAULT untouched if user set it globally
if [[ $exit_code -ne 0 ]]; then if [[ $exit_code -ne 0 ]]; then

2
lib/ui/menu_paginated.sh
View File

@@ -182,6 +182,7 @@ paginated_multi_select() {
# Cleanup function # Cleanup function
cleanup() { cleanup() {
trap - EXIT INT TERM trap - EXIT INT TERM
unset MOLE_READ_KEY_FORCE_CHAR
export MOLE_MENU_SORT_MODE="${sort_mode:-name}" export MOLE_MENU_SORT_MODE="${sort_mode:-name}"
export MOLE_MENU_SORT_REVERSE="${sort_reverse:-false}" export MOLE_MENU_SORT_REVERSE="${sort_reverse:-false}"
restore_terminal restore_terminal
@@ -862,6 +863,7 @@ paginated_multi_select() {
trap - EXIT INT TERM trap - EXIT INT TERM
MOLE_SELECTION_RESULT="$final_result" MOLE_SELECTION_RESULT="$final_result"
unset MOLE_READ_KEY_FORCE_CHAR
export MOLE_MENU_SORT_MODE="${sort_mode:-name}" export MOLE_MENU_SORT_MODE="${sort_mode:-name}"
export MOLE_MENU_SORT_REVERSE="${sort_reverse:-false}" export MOLE_MENU_SORT_REVERSE="${sort_reverse:-false}"
restore_terminal restore_terminal