mirrors/Mole
1
0
Fork 0
mirror of https://github.com/tw93/Mole.git synced 2026-03-24 12:20:06 +00:00
Code Activity

fix(version): avoid SIGPIPE in Homebrew install detection

Browse Source 
Cache Homebrew formula output and use shell string matching to prevent pipefail SIGPIPE races that could misreport script installs as manual. Closes #513.
This commit is contained in:
tw93
2026-03-01 19:56:33 +08:00
parent 3b5707b078
commit 172742b0d5
1 changed files with 21 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
mole
View File

@@ -38,14 +38,26 @@ get_latest_version_from_github() {
} }
# Install detection (Homebrew vs manual). # Install detection (Homebrew vs manual).
# Uses variable capture + string matching to avoid SIGPIPE under pipefail.
is_homebrew_install() { is_homebrew_install() {
local mole_path local mole_path link_target brew_list="" has_brew=false
mole_path=$(command -v mole 2> /dev/null) || return 1 mole_path=$(command -v mole 2> /dev/null) || return 1
if [[ -L "$mole_path" ]] && readlink "$mole_path" | grep -q "Cellar/mole"; then # Cache brew list once if brew is available
if command -v brew > /dev/null 2>&1; then if command -v brew > /dev/null 2>&1; then
brew list --formula 2> /dev/null | grep -q "^mole$" && return 0 has_brew=true
else brew_list=$(brew list --formula 2> /dev/null) || true
fi
# Helper to check if mole is in brew list
_mole_in_brew_list() {
[[ -n "$brew_list" ]] && [[ $'\n'"$brew_list"$'\n' == *$'\n'"mole"$'\n'* ]]
}
if [[ -L "$mole_path" ]]; then
link_target=$(readlink "$mole_path" 2> /dev/null) || true
if [[ "$link_target" == *"Cellar/mole"* ]]; then
$has_brew && _mole_in_brew_list && return 0
return 1 return 1
fi fi
fi fi
@@ -54,8 +66,8 @@ is_homebrew_install() {
case "$mole_path" in case "$mole_path" in
/opt/homebrew/bin/mole | /usr/local/bin/mole) /opt/homebrew/bin/mole | /usr/local/bin/mole)
if [[ -d /opt/homebrew/Cellar/mole ]] || [[ -d /usr/local/Cellar/mole ]]; then if [[ -d /opt/homebrew/Cellar/mole ]] || [[ -d /usr/local/Cellar/mole ]]; then
if command -v brew > /dev/null 2>&1; then if $has_brew; then
brew list --formula 2> /dev/null | grep -q "^mole$" && return 0 _mole_in_brew_list && return 0
else else
return 0 # Cellar exists, probably Homebrew install return 0 # Cellar exists, probably Homebrew install
fi fi
@@ -64,11 +76,11 @@ is_homebrew_install() {
esac esac
fi fi
if command -v brew > /dev/null 2>&1; then if $has_brew; then
local brew_prefix local brew_prefix
brew_prefix=$(brew --prefix 2> /dev/null) brew_prefix=$(brew --prefix 2> /dev/null)
if [[ -n "$brew_prefix" && "$mole_path" == "$brew_prefix/bin/mole" && -d "$brew_prefix/Cellar/mole" ]]; then if [[ -n "$brew_prefix" && "$mole_path" == "$brew_prefix/bin/mole" && -d "$brew_prefix/Cellar/mole" ]]; then
brew list --formula 2> /dev/null | grep -q "^mole$" && return 0 _mole_in_brew_list && return 0
fi fi
fi fi