🐛 (Firefox) Attachments with spaces in name don't download correctly #83

Merged
MrLyallCSIT merged 3 commits from bug/78 into main 2020-08-13 19:36:05 +00:00
4 changed files with 7 additions and 6 deletions

View File

@@ -10,6 +10,6 @@ jobs:
steps: steps:
- uses: alex-page/github-project-automation-plus@v0.2.4 - uses: alex-page/github-project-automation-plus@v0.2.4
with: with:
project: FHeD v1.0 project: v1.0
column: In Progress column: In progress
repo-token: ${{ secrets.AUTO_TOKEN }} repo-token: ${{ secrets.GITHUB_TOKEN }}

View File

@@ -20,7 +20,7 @@
finfo_close($finfo); finfo_close($finfo);
//Use Content-Disposition: attachment to specify the filename //Use Content-Disposition: attachment to specify the filename
header('Content-Disposition: attachment; filename='.$remote_filename); header('Content-Disposition: attachment; filename="'.$remote_filename.'"');
//No cache //No cache
header('Expires: 0'); header('Expires: 0');

View File

@@ -5,6 +5,7 @@
// Perform the OIDC authentication // Perform the OIDC authentication
try { try {
$oidc->authenticate(); $oidc->authenticate();
$_SESSION['access_token'] = $oidc->requestClientCredentialsToken()->access_token;
$oidc_user = array( $oidc_user = array(
'sub' => $oidc->requestUserInfo('sub'), 'sub' => $oidc->requestUserInfo('sub'),
'username' => $oidc->requestUserInfo('preferred_username'), 'username' => $oidc->requestUserInfo('preferred_username'),

View File

@@ -2,7 +2,7 @@
$PAGE_NAME = "Logging out..."; $PAGE_NAME = "Logging out...";
require_once __DIR__ . "/../../includes/prereqs.php"; require_once __DIR__ . "/../../includes/prereqs.php";
$access_token = $_SESSION['access_token'];
session_destroy(); session_destroy();
$oidc->signOut($access_token, $_ENV['APP_URL']);
header('Location: /');
?> ?>