archives/FHeD
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases 40 Activity

🚨 Testing New Existing Page #94

Merged
MrLyallCSIT merged 11 commits from feat/85 into main 2020-08-14 20:23:45 +00:00
Conversation 6 Commits 11 Files Changed 2 +172
MrLyallCSIT commented 2020-08-14 17:07:10 +00:00 (Migrated from github.com)
Copy Link

Description

Creation of newexisting page with new design for existing requests page. Checking to see if POC works and system will not break. Once testing is complete. system will be implemented into the main app and linked.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes the documentation (README.md).
## Description Creation of newexisting page with new design for existing requests page. Checking to see if POC works and system will not break. Once testing is complete. system will be implemented into the main app and linked. ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist: - [x] I read & comply with the [contributing guidelines](https://github.com/luketainton/FHeD/blob/main/.github/CONTRIBUTING.md) - [x] I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers. - [x] I have made corresponding changes the documentation (README.md).
luketainton (Migrated from github.com) requested changes 2020-08-14 17:34:50 +00:00
.github/issue-branch.yml
@@ -10,4 +10,6 @@ branches:
prefix: epic/
luketainton (Migrated from github.com) commented 2020-08-14 17:33:51 +00:00
Copy Link

Pls change to auto/ - less characters to type when I'm switching branches :)

Pls change to auto/ - less characters to type when I'm switching branches :)
app/includes/header.php
luketainton (Migrated from github.com) commented 2020-08-14 17:34:34 +00:00
Copy Link

What's going on here?

What's going on here?
MrLyallCSIT (Migrated from github.com) reviewed 2020-08-14 17:49:00 +00:00
.github/issue-branch.yml
@@ -10,4 +10,6 @@ branches:
prefix: epic/
MrLyallCSIT (Migrated from github.com) commented 2020-08-14 17:49:00 +00:00
Copy Link

which line 13 or 14?

which line 13 or 14?
MrLyallCSIT (Migrated from github.com) reviewed 2020-08-14 17:49:22 +00:00
app/includes/header.php
MrLyallCSIT (Migrated from github.com) commented 2020-08-14 17:49:22 +00:00
Copy Link

Scripting required for bootstrap responsive tabs and dynamic content

Scripting required for bootstrap responsive tabs and dynamic content
luketainton (Migrated from github.com) reviewed 2020-08-14 19:30:38 +00:00
.github/issue-branch.yml
@@ -10,4 +10,6 @@ branches:
prefix: epic/
luketainton (Migrated from github.com) commented 2020-08-14 19:30:38 +00:00
Copy Link

14

14
luketainton (Migrated from github.com) reviewed 2020-08-14 19:31:21 +00:00
app/includes/header.php
luketainton (Migrated from github.com) commented 2020-08-14 19:31:21 +00:00
Copy Link

The CSS file is already hosted with the site (see above lines) and the JS is included in includes/footer

The CSS file is already hosted with the site (see above lines) and the JS is included in includes/footer
luketainton (Migrated from github.com) approved these changes 2020-08-14 20:23:40 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
MrLyallCSIT
luketainton
Labels
Clear labels
dependencies
Pull requests that update a dependency file
 release:major
Auto Version - Major release
 release:minor
Auto Version - Minor release
 release:patch
Auto Version - Patch release
 status:duplicate
This issue or pull request already exists
 status:stale
Auto-closed due to inactivity
 type:bug
Something isn't working
 type:docs
Improvements or additions to documentation
 type:epic
Major/breaking changes to the codebase
 type:feature
New feature or request
 type:question
Further information is requested
No Label type:epic type:feature
Milestone
No items
No Milestone
Assignees
Clear assignees
luke
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: archives/FHeD#94
Delete Branch "feat/85"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?